Merge pull request #180 from elBroom/add-resp-callback

Add transport response callback

Author: vladlutkov

Diff for: conn.go

@@ -277,6 +277,12 @@ func (c *conn) doRequest(ctx context.Context, req *http.Request) (io.ReadCloser,
 		c.cancel = nil
 		return nil, fmt.Errorf("doRequest: transport failed to send a request to ClickHouse: %w", err)
 	}
+
+        if err = callCtxTransportCallback(ctx, req, resp); err != nil {
+                c.cancel = nil
+                return nil, fmt.Errorf("doRequest: transport callback: %w", err)
+        }
+
 	if resp.StatusCode != 200 {
 		msg, err := readResponse(resp)
 		c.cancel = nil
@@ -287,6 +293,7 @@ func (c *conn) doRequest(ctx context.Context, req *http.Request) (io.ReadCloser,
 		// response
 		return nil, newError(string(msg))
 	}
+
 	return resp.Body, nil
 }
 

Diff for: ctx.go

@@ -0,0 +1,28 @@
+package clickhouse
+
+import (
+	"context"
+	"net/http"
+)
+
+type ctxKey uint8
+
+const (
+	ctxTransportCallbackKey ctxKey = iota + 1
+)
+
+// TransportCallback is a transport response callback. Called before processing the http response.
+type TransportCallback func(*http.Request, *http.Response) error
+
+// CtxAddTransportCallback adds callback to work with transport response.
+func CtxAddTransportCallback(ctx context.Context, f TransportCallback) context.Context {
+	return context.WithValue(ctx, ctxTransportCallbackKey, f)
+}
+
+func callCtxTransportCallback(ctx context.Context, req *http.Request, resp *http.Response) error {
+	if f, ok := ctx.Value(ctxTransportCallbackKey).(TransportCallback); ok && f != nil {
+		return f(req, resp)
+	}
+
+	return nil
+}

Diff for: ctx_test.go

@@ -0,0 +1,41 @@
+package clickhouse
+
+import (
+	"context"
+	"errors"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func Test_CtxAddTransportCallback(t *testing.T) {
+	var flag bool
+	ctx := context.Background()
+
+	ctx = CtxAddTransportCallback(ctx, func(_ *http.Request, _ *http.Response) error {
+		flag = true
+		return nil
+	})
+
+	assert.NoError(t, callCtxTransportCallback(ctx,
+		httptest.NewRequest(http.MethodGet, "http://localhost", nil), httptest.NewRecorder().Result(),
+	))
+	assert.True(t, flag)
+}
+
+func Test_CtxAddTransportCallback_err(t *testing.T) {
+	var flag bool
+	ctx := context.Background()
+
+	ctx = CtxAddTransportCallback(ctx, func(_ *http.Request, _ *http.Response) error {
+		flag = true
+		return errors.New("some error")
+	})
+
+	assert.EqualError(t, callCtxTransportCallback(ctx,
+		httptest.NewRequest(http.MethodGet, "http://localhost", nil), httptest.NewRecorder().Result(),
+	), "some error")
+	assert.True(t, flag)
+}