Skip to content

Commit 361dc01

Browse files
authored
Merge pull request #186 from kirphone/fix-kill-query
fix killQuery if initial query has args
2 parents a540e28 + 71e4d03 commit 361dc01

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

Diff for: conn.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ func (c *conn) beginTx(ctx context.Context) (driver.Tx, error) {
191191
return c, nil
192192
}
193193

194-
func (c *conn) killQuery(req *http.Request, args []driver.Value) error {
194+
func (c *conn) killQuery(req *http.Request) error {
195195
if !c.killQueryOnErr {
196196
return nil
197197
}
@@ -206,7 +206,7 @@ func (c *conn) killQuery(req *http.Request, args []driver.Value) error {
206206
}
207207
ctx, cancelFunc := context.WithTimeout(context.Background(), timeout)
208208
defer cancelFunc()
209-
req, err := c.buildRequest(ctx, query, args)
209+
req, err := c.buildRequest(ctx, query, nil)
210210
if err != nil {
211211
return err
212212
}
@@ -233,7 +233,7 @@ func (c *conn) query(ctx context.Context, query string, args []driver.Value) (dr
233233
body, err := c.doRequest(ctx, req)
234234
if err != nil {
235235
if _, ok := err.(*Error); !ok && err != driver.ErrBadConn {
236-
killErr := c.killQuery(req, args)
236+
killErr := c.killQuery(req)
237237
if killErr != nil {
238238
c.log("error from killQuery", killErr)
239239
}
@@ -278,10 +278,10 @@ func (c *conn) doRequest(ctx context.Context, req *http.Request) (io.ReadCloser,
278278
return nil, fmt.Errorf("doRequest: transport failed to send a request to ClickHouse: %w", err)
279279
}
280280

281-
if err = callCtxTransportCallback(ctx, req, resp); err != nil {
282-
c.cancel = nil
283-
return nil, fmt.Errorf("doRequest: transport callback: %w", err)
284-
}
281+
if err = callCtxTransportCallback(ctx, req, resp); err != nil {
282+
c.cancel = nil
283+
return nil, fmt.Errorf("doRequest: transport callback: %w", err)
284+
}
285285

286286
if resp.StatusCode != 200 {
287287
msg, err := readResponse(resp)

0 commit comments

Comments
 (0)