GetMailingList returns empty struct even though address is present

[tommed]

I have the code:

log.Printf("fetching mailing list <%s>", address)
ml, err := mg.GetMailingList(c, address)

I check and err is nil. The mailing list returned is an empty struct with nothing set in it.

When I check the log entry, it says:

"fetching mailing list [email protected]"

And as you can see, the mailing list '[email protected]' does indeed exist:

It is also returned in ListMailingLists with the same address, so I know it is correct.

[tommed]

The response from the API is returning:

{
  "list": {
    "access_level": "readonly",
    "address": "[email protected]",
  //...
}

But the model you're trying to json serialise it into is mailingListResponse, which uses member:

type mailingListResponse struct {
	MailingList MailingList `json:"member"`
}

var resp mailingListResponse
err = response.parseFromJSON(&resp)
return resp.MailingList, err

Which is probably why resp.MailingList is not being set.

[tommed]

Is no one monitoring or maintaining this library? You'd expect someone to be doing this given it's an official repo.
Does that mean this code is not being security patched and Dependabot patches aren't being applied?

[thrawn01]

Looks like I introduced this error when I converted the library to local testing. I'll have a PR up in a few moments.

[thrawn01]

New Release https://github.com/mailgun/mailgun-go/releases/tag/v4.12.0