Skip to content

Commit 94238f7

Browse files
committed
chore: upgrade rules_sass
We no longer need the patch file
1 parent 901df38 commit 94238f7

File tree

5 files changed

+12
-78
lines changed

5 files changed

+12
-78
lines changed

BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ pkg_npm(
7272
srcs = glob(["*.bzl"]) + [
7373
"BUILD.bazel",
7474
"LICENSE",
75-
"rules_sass.issue127.patch",
7675
],
7776
substitutions = COMMON_REPLACEMENTS,
7877
deps = [

examples/angular/WORKSPACE

+4-10
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,11 @@ http_archive(
3636
# Fetch sass rules for compiling sass files
3737
http_archive(
3838
name = "io_bazel_rules_sass",
39-
patch_args = ["-p1"],
40-
# We need the latest rules_sass to get the --bazel_patch_module_resolver behavior
41-
# However it seems to have a bug, so we patch back to the prior dart-sass version.
42-
# See https://github.com/bazelbuild/rules_sass/issues/127
43-
# TODO(alexeagle): fix upstream and remove patch
44-
patches = ["@build_bazel_rules_nodejs//:rules_sass.issue127.patch"],
45-
sha256 = "8392cf8910db2b1dc3b488ea18113bfe4fd666037bf8ec30d2a3f08fc602a6d8",
46-
strip_prefix = "rules_sass-1.30.0",
39+
sha256 = "c6249cf64dffbc81312191800b0984b5197d77864c13d0dc4d469937cc3f8108",
40+
strip_prefix = "rules_sass-1.32.11",
4741
urls = [
48-
"https://github.com/bazelbuild/rules_sass/archive/1.30.0.zip",
49-
"https://mirror.bazel.build/github.com/bazelbuild/rules_sass/archive/1.30.0.zip",
42+
"https://github.com/bazelbuild/rules_sass/archive/1.32.11.zip",
43+
"https://mirror.bazel.build/github.com/bazelbuild/rules_sass/archive/1.32.11.zip",
5044
],
5145
)
5246

examples/angular_view_engine/WORKSPACE

+4-10
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,11 @@ http_archive(
2323
# Fetch sass rules for compiling sass files
2424
http_archive(
2525
name = "io_bazel_rules_sass",
26-
patch_args = ["-p1"],
27-
# We need the latest rules_sass to get the --bazel_patch_module_resolver behavior
28-
# However it seems to have a bug, so we patch back to the prior dart-sass version.
29-
# See https://github.com/bazelbuild/rules_sass/issues/127
30-
# TODO(alexeagle): fix upstream and remove patch
31-
patches = ["@build_bazel_rules_nodejs//:rules_sass.issue127.patch"],
32-
sha256 = "8392cf8910db2b1dc3b488ea18113bfe4fd666037bf8ec30d2a3f08fc602a6d8",
33-
strip_prefix = "rules_sass-1.30.0",
26+
sha256 = "c6249cf64dffbc81312191800b0984b5197d77864c13d0dc4d469937cc3f8108",
27+
strip_prefix = "rules_sass-1.32.11",
3428
urls = [
35-
"https://github.com/bazelbuild/rules_sass/archive/1.30.0.zip",
36-
"https://mirror.bazel.build/github.com/bazelbuild/rules_sass/archive/1.30.0.zip",
29+
"https://github.com/bazelbuild/rules_sass/archive/1.32.11.zip",
30+
"https://mirror.bazel.build/github.com/bazelbuild/rules_sass/archive/1.32.11.zip",
3731
],
3832
)
3933

package.bzl

+4-10
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,11 @@ def rules_nodejs_dev_dependencies():
3131
_maybe(
3232
http_archive,
3333
name = "io_bazel_rules_sass",
34-
patch_args = ["-p1"],
35-
# We need the latest rules_sass to get the --bazel_patch_module_resolver behavior
36-
# However it seems to have a bug, so we patch back to the prior dart-sass version.
37-
# See https://github.com/bazelbuild/rules_sass/issues/127
38-
# TODO(alexeagle): fix upstream and remove patch
39-
patches = ["@build_bazel_rules_nodejs//:rules_sass.issue127.patch"],
40-
sha256 = "8392cf8910db2b1dc3b488ea18113bfe4fd666037bf8ec30d2a3f08fc602a6d8",
41-
strip_prefix = "rules_sass-1.30.0",
34+
sha256 = "c6249cf64dffbc81312191800b0984b5197d77864c13d0dc4d469937cc3f8108",
35+
strip_prefix = "rules_sass-1.32.11",
4236
urls = [
43-
"https://github.com/bazelbuild/rules_sass/archive/1.30.0.zip",
44-
"https://mirror.bazel.build/github.com/bazelbuild/rules_sass/archive/1.30.0.zip",
37+
"https://github.com/bazelbuild/rules_sass/archive/1.32.11.zip",
38+
"https://mirror.bazel.build/github.com/bazelbuild/rules_sass/archive/1.32.11.zip",
4539
],
4640
)
4741

rules_sass.issue127.patch

-47
This file was deleted.

0 commit comments

Comments
 (0)