From 24b3b67a10146dd1d2ed9206caf84df95d43ab96 Mon Sep 17 00:00:00 2001 From: sergey Date: Sat, 16 Jan 2021 15:07:09 +0200 Subject: [PATCH] Magento_Customer: Avoid using deprecated escape* methods from AbstractBlock --- .../Block/Account/AuthenticationPopup.php | 2 +- .../Address/Renderer/DefaultRenderer.php | 2 +- .../Magento/Customer/Block/Adminhtml/Edit.php | 4 +- .../Edit/Tab/View/Grid/Renderer/Item.php | 6 +- .../Wishlist/Grid/Renderer/Description.php | 2 +- .../Customer/Block/Adminhtml/Group/Edit.php | 2 +- .../Magento/Customer/Block/Widget/Name.php | 4 +- .../create/address/form/renderer/vat.phtml | 11 ++- .../templates/system/config/validatevat.phtml | 19 ++-- .../view/adminhtml/templates/tab/cart.phtml | 31 ++++--- .../templates/tab/view/personal_info.phtml | 43 +++++---- .../adminhtml/templates/tab/view/sales.phtml | 35 +++---- .../account/authentication-popup.phtml | 9 +- .../frontend/templates/account/customer.phtml | 7 +- .../templates/account/dashboard/address.phtml | 17 ++-- .../templates/account/dashboard/info.phtml | 31 ++++--- .../templates/account/link/back.phtml | 5 +- .../templates/account/navigation.phtml | 7 +- .../frontend/templates/address/book.phtml | 27 +++--- .../frontend/templates/address/grid.phtml | 57 ++++++------ .../templates/form/confirmation.phtml | 17 ++-- .../view/frontend/templates/form/edit.phtml | 59 ++++++------ .../templates/form/forgotpassword.phtml | 19 ++-- .../view/frontend/templates/form/login.phtml | 27 +++--- .../frontend/templates/form/newsletter.phtml | 17 ++-- .../form/resetforgottenpassword.phtml | 23 +++-- .../frontend/templates/js/customer-data.phtml | 11 ++- .../js/customer-data/invalidation-rules.phtml | 7 +- .../view/frontend/templates/logout.phtml | 9 +- .../confirmAccountSuccessMessage.phtml | 7 +- .../customerAlreadyExistsErrorMessage.phtml | 7 +- ...tomerVatBillingAddressSuccessMessage.phtml | 7 +- ...omerVatShippingAddressSuccessMessage.phtml | 7 +- .../view/frontend/templates/newcustomer.phtml | 11 ++- .../frontend/templates/widget/company.phtml | 13 ++- .../view/frontend/templates/widget/dob.phtml | 15 +-- .../view/frontend/templates/widget/fax.phtml | 13 ++- .../frontend/templates/widget/gender.phtml | 11 ++- .../view/frontend/templates/widget/name.phtml | 93 ++++++++++--------- .../frontend/templates/widget/taxvat.phtml | 9 +- .../frontend/templates/widget/telephone.phtml | 13 ++- 41 files changed, 408 insertions(+), 308 deletions(-) diff --git a/app/code/Magento/Customer/Block/Account/AuthenticationPopup.php b/app/code/Magento/Customer/Block/Account/AuthenticationPopup.php index 6695d7fd6d3e8..29b62d85ae245 100644 --- a/app/code/Magento/Customer/Block/Account/AuthenticationPopup.php +++ b/app/code/Magento/Customer/Block/Account/AuthenticationPopup.php @@ -57,7 +57,7 @@ public function getJsLayout() public function getConfig() { return [ - 'autocomplete' => $this->escapeHtml($this->isAutocompleteEnabled()), + 'autocomplete' => $this->_escaper->escapeHtml($this->isAutocompleteEnabled()), 'customerRegisterUrl' => $this->escapeUrl($this->getCustomerRegisterUrlUrl()), 'customerForgotPasswordUrl' => $this->escapeUrl($this->getCustomerForgotPasswordUrl()), 'baseUrl' => $this->escapeUrl($this->getBaseUrl()) diff --git a/app/code/Magento/Customer/Block/Address/Renderer/DefaultRenderer.php b/app/code/Magento/Customer/Block/Address/Renderer/DefaultRenderer.php index c10ff421b7f92..ba43578e3583f 100644 --- a/app/code/Magento/Customer/Block/Address/Renderer/DefaultRenderer.php +++ b/app/code/Magento/Customer/Block/Address/Renderer/DefaultRenderer.php @@ -194,7 +194,7 @@ public function renderArray($addressAttributes, $format = null) } if ($this->getType()->getEscapeHtml()) { foreach ($data as $key => $value) { - $data[$key] = $this->escapeHtml($value); + $data[$key] = $this->_escaper->escapeHtml($value); } } $format = $format !== null ? $format : $this->getFormatArray($addressAttributes); diff --git a/app/code/Magento/Customer/Block/Adminhtml/Edit.php b/app/code/Magento/Customer/Block/Adminhtml/Edit.php index 973016baba29c..b29c008d02206 100644 --- a/app/code/Magento/Customer/Block/Adminhtml/Edit.php +++ b/app/code/Magento/Customer/Block/Adminhtml/Edit.php @@ -121,7 +121,7 @@ protected function _construct() 'invalidate_token', [ 'label' => __('Force Sign-In'), - 'onclick' => 'deleteConfirm(\'' . $this->escapeJs($this->escapeHtml($deleteConfirmMsg)) . + 'onclick' => 'deleteConfirm(\'' . $this->_escaper->escapeJs($this->_escaper->escapeHtml($deleteConfirmMsg)) . '\', \'' . $url . '\')', 'class' => 'invalidate-token' ], @@ -161,7 +161,7 @@ public function getHeaderText() $customerId = $this->getCustomerId(); if ($customerId) { $customerData = $this->customerRepository->getById($customerId); - return $this->escapeHtml($this->_viewHelper->getCustomerName($customerData)); + return $this->_escaper->escapeHtml($this->_viewHelper->getCustomerName($customerData)); } else { return __('New Customer'); } diff --git a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/Grid/Renderer/Item.php b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/Grid/Renderer/Item.php index f372d79258590..ea09b1ff96d7c 100644 --- a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/Grid/Renderer/Item.php +++ b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/View/Grid/Renderer/Item.php @@ -123,7 +123,7 @@ public function render(\Magento\Framework\DataObject $item) $this->setItem($item); $product = $this->getProduct(); $options = $this->getOptionList(); - return $options ? $this->_renderItemOptions($product, $options) : $this->escapeHtml($product->getName()); + return $options ? $this->_renderItemOptions($product, $options) : $this->_escaper->escapeHtml($product->getName()); } /** @@ -135,12 +135,12 @@ public function render(\Magento\Framework\DataObject $item) */ protected function _renderItemOptions(Product $product, array $options) { - $html = '
' . $this->escapeHtml( + $html = '
' . $this->_escaper->escapeHtml( $product->getName() ) . '
' . '
'; foreach ($options as $option) { $formattedOption = $this->getFormattedOptionValue($option); - $html .= '
' . $this->escapeHtml($option['label']) . '
'; + $html .= '
' . $this->_escaper->escapeHtml($option['label']) . '
'; $html .= '
' . $formattedOption['value'] . '
'; } $html .= '
'; diff --git a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Wishlist/Grid/Renderer/Description.php b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Wishlist/Grid/Renderer/Description.php index aef91184fc782..c6d65f094adfd 100644 --- a/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Wishlist/Grid/Renderer/Description.php +++ b/app/code/Magento/Customer/Block/Adminhtml/Edit/Tab/Wishlist/Grid/Renderer/Description.php @@ -18,6 +18,6 @@ class Description extends \Magento\Backend\Block\Widget\Grid\Column\Renderer\Abs */ public function render(\Magento\Framework\DataObject $row) { - return nl2br($this->escapeHtml($row->getData($this->getColumn()->getIndex()))); + return nl2br($this->_escaper->escapeHtml($row->getData($this->getColumn()->getIndex()))); } } diff --git a/app/code/Magento/Customer/Block/Adminhtml/Group/Edit.php b/app/code/Magento/Customer/Block/Adminhtml/Group/Edit.php index be2d143e7f864..94ddc84032aae 100644 --- a/app/code/Magento/Customer/Block/Adminhtml/Group/Edit.php +++ b/app/code/Magento/Customer/Block/Adminhtml/Group/Edit.php @@ -87,7 +87,7 @@ public function getHeaderText() return __('New Customer Group'); } else { $group = $this->groupRepository->getById($groupId); - return __('Edit Customer Group "%1"', $this->escapeHtml($group->getCode())); + return __('Edit Customer Group "%1"', $this->_escaper->escapeHtml($group->getCode())); } } diff --git a/app/code/Magento/Customer/Block/Widget/Name.php b/app/code/Magento/Customer/Block/Widget/Name.php index 6f1b051af7465..b933587b9e784 100644 --- a/app/code/Magento/Customer/Block/Widget/Name.php +++ b/app/code/Magento/Customer/Block/Widget/Name.php @@ -107,7 +107,7 @@ public function getPrefixOptions() if ($this->getObject() && !empty($prefixOptions)) { $prefixOption = $this->getObject()->getPrefix(); - $oldPrefix = $this->escapeHtml(trim($prefixOption)); + $oldPrefix = $this->_escaper->escapeHtml(trim($prefixOption)); if ($prefixOption !== null && !isset($prefixOptions[$oldPrefix]) && !isset($prefixOptions[$prefixOption])) { $prefixOptions[$oldPrefix] = $oldPrefix; } @@ -165,7 +165,7 @@ public function getSuffixOptions() $suffixOptions = $this->options->getNameSuffixOptions(); if ($this->getObject() && !empty($suffixOptions)) { $suffixOption = $this->getObject()->getSuffix(); - $oldSuffix = $this->escapeHtml(trim($suffixOption)); + $oldSuffix = $this->_escaper->escapeHtml(trim($suffixOption)); if ($suffixOption !== null && !isset($suffixOptions[$oldSuffix]) && !isset($suffixOptions[$suffixOption])) { $suffixOptions[$oldSuffix] = $oldSuffix; } diff --git a/app/code/Magento/Customer/view/adminhtml/templates/sales/order/create/address/form/renderer/vat.phtml b/app/code/Magento/Customer/view/adminhtml/templates/sales/order/create/address/form/renderer/vat.phtml index b792bc27f5b64..8b8a5b3617a22 100644 --- a/app/code/Magento/Customer/view/adminhtml/templates/sales/order/create/address/form/renderer/vat.phtml +++ b/app/code/Magento/Customer/view/adminhtml/templates/sales/order/create/address/form/renderer/vat.phtml @@ -4,7 +4,10 @@ * See COPYING.txt for license details. */ -/** @var \Magento\Customer\Block\Adminhtml\Sales\Order\Address\Form\Renderer\Vat $block */ +/** + * @var \Magento\Customer\Block\Adminhtml\Sales\Order\Address\Form\Renderer\Vat $block + * @var \Magento\Framework\Escaper $escaper + */ $_element = $block->getElement(); $_note = $_element->getNote(); @@ -17,11 +20,11 @@ $_validateButton = $block->getValidateButton(); getLabelHtml() ?> -
+
getElementHtml() ?> -
escapeHtmlAttr($_class)}-note" : '' ?>" id="note_escapeHtmlAttr($_element->getId()) ?>"> - escapeHtml($_note) ?> +
escapeHtmlAttr($_class)}-note" : '' ?>" id="note_escapeHtmlAttr($_element->getId()) ?>"> + escapeHtml($_note) ?>
diff --git a/app/code/Magento/Customer/view/adminhtml/templates/system/config/validatevat.phtml b/app/code/Magento/Customer/view/adminhtml/templates/system/config/validatevat.phtml index f4a3d2db6b687..322a0f02b6bb1 100644 --- a/app/code/Magento/Customer/view/adminhtml/templates/system/config/validatevat.phtml +++ b/app/code/Magento/Customer/view/adminhtml/templates/system/config/validatevat.phtml @@ -4,15 +4,16 @@ * See COPYING.txt for license details. */ -/** @var \Magento\Customer\Block\Adminhtml\System\Config\Validatevat $block */ -/** @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer */ -?> +/** + * @var \Magento\Customer\Block\Adminhtml\System\Config\Validatevat $block + * @var \Magento\Framework\Escaper $escaper + * @var \Magento\Framework\View\Helper\SecureHtmlRenderer $secureRenderer + */ -escapeJs($block->getMerchantCountryField()); - $merchantVatNumberField = $block->escapeJs($block->getMerchantVatNumberField()); - $ajaxUrl = $block->escapeJs($block->getAjaxUrl()); - $errorMessage = $block->escapeJs($block->escapeHtml(__('Error during VAT Number verification.'))); + $merchantCountryField = $escaper->escapeJs($block->getMerchantCountryField()); + $merchantVatNumberField = $escaper->escapeJs($block->getMerchantVatNumberField()); + $ajaxUrl = $escaper->escapeJs($block->getAjaxUrl()); + $errorMessage = $escaper->escapeJs($escaper->escapeHtml(__('Error during VAT Number verification.'))); $scriptString = <<