From 667e276ffcb41927bb07648f5e0e01ad8a733e5e Mon Sep 17 00:00:00 2001 From: vgelani Date: Mon, 20 Aug 2018 16:10:12 +0530 Subject: [PATCH 1/3] Fixed undefinded shipping method name issue --- .../Checkout/view/frontend/web/js/view/summary/shipping.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js b/app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js index 3fda260339254..db30d0a2647b1 100644 --- a/app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js +++ b/app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js @@ -22,13 +22,18 @@ define([ */ getShippingMethodTitle: function () { var shippingMethod; + var shippingMethodTitle = ''; if (!this.isCalculated()) { return ''; } shippingMethod = quote.shippingMethod(); - return shippingMethod ? shippingMethod['carrier_title'] + ' - ' + shippingMethod['method_title'] : ''; + if (typeof(shippingMethod['method_title']) !== 'undefined') { + shippingMethodTitle = ' - ' + shippingMethod['method_title']; + } + + return shippingMethod ? shippingMethod['carrier_title'] + shippingMethodTitle : ''; }, /** From d85dd69d40acdcc4934a9f0f2fc3ebbbb9f8eb40 Mon Sep 17 00:00:00 2001 From: Vishal Gelani Date: Mon, 27 Aug 2018 16:25:58 +0530 Subject: [PATCH 2/3] Update shipping.js --- .../Checkout/view/frontend/web/js/view/summary/shipping.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js b/app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js index db30d0a2647b1..07504b8cae1a0 100644 --- a/app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js +++ b/app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js @@ -21,15 +21,14 @@ define([ * @return {*} */ getShippingMethodTitle: function () { - var shippingMethod; - var shippingMethodTitle = ''; + var shippingMethod = shippingMethodTitle = ''; if (!this.isCalculated()) { return ''; } shippingMethod = quote.shippingMethod(); - if (typeof(shippingMethod['method_title']) !== 'undefined') { + if (typeof (shippingMethod['method_title']) !== 'undefined') { shippingMethodTitle = ' - ' + shippingMethod['method_title']; } From cd7c2b197cfb9db5e7aa1de10dfa95528bd57ad3 Mon Sep 17 00:00:00 2001 From: Volodymyr Zaets Date: Wed, 12 Sep 2018 17:21:37 +0300 Subject: [PATCH 3/3] [Forwardport] Fixed undefinded shipping method name issue #17492 --- .../Checkout/view/frontend/web/js/view/summary/shipping.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js b/app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js index 07504b8cae1a0..f4f5f192e646a 100644 --- a/app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js +++ b/app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js @@ -21,7 +21,8 @@ define([ * @return {*} */ getShippingMethodTitle: function () { - var shippingMethod = shippingMethodTitle = ''; + var shippingMethod = '', + shippingMethodTitle = ''; if (!this.isCalculated()) { return ''; @@ -32,7 +33,7 @@ define([ shippingMethodTitle = ' - ' + shippingMethod['method_title']; } - return shippingMethod ? shippingMethod['carrier_title'] + shippingMethodTitle : ''; + return shippingMethod ? shippingMethod['carrier_title'] + shippingMethodTitle : shippingMethod['carrier_title']; }, /**