diff --git a/app/code/Magento/Cms/Model/Config/Source/Block.php b/app/code/Magento/Cms/Model/Config/Source/Block.php new file mode 100644 index 0000000000000..85dc4e4dd24bf --- /dev/null +++ b/app/code/Magento/Cms/Model/Config/Source/Block.php @@ -0,0 +1,48 @@ +collectionFactory = $collectionFactory; + } + + /** + * {@inheritdoc} + */ + public function toOptionArray() + { + if (!$this->options) { + $this->options = $this->collectionFactory->create()->toOptionIdArray(); + } + + return $this->options; + } +} diff --git a/app/code/Magento/Cms/Model/ResourceModel/AbstractCollection.php b/app/code/Magento/Cms/Model/ResourceModel/AbstractCollection.php index cd5945c2f47cb..2a67378614445 100644 --- a/app/code/Magento/Cms/Model/ResourceModel/AbstractCollection.php +++ b/app/code/Magento/Cms/Model/ResourceModel/AbstractCollection.php @@ -176,4 +176,32 @@ public function getSelectCountSql() return $countSelect; } + + /** + * Returns pairs identifier - title for unique identifiers + * and pairs identifier|entity_id - title for non-unique after first + * + * @return array + */ + public function toOptionIdArray() + { + $res = []; + $existingIdentifiers = []; + foreach ($this as $item) { + $identifier = $item->getData('identifier'); + + $data['value'] = $identifier; + $data['label'] = $item->getData('title'); + + if (in_array($identifier, $existingIdentifiers)) { + $data['value'] .= '|' . $item->getData($this->getIdFieldName()); + } else { + $existingIdentifiers[] = $identifier; + } + + $res[] = $data; + } + + return $res; + } } diff --git a/app/code/Magento/Cms/Model/ResourceModel/Page/Collection.php b/app/code/Magento/Cms/Model/ResourceModel/Page/Collection.php index 98c071890be46..4ccc2c8f6e77d 100644 --- a/app/code/Magento/Cms/Model/ResourceModel/Page/Collection.php +++ b/app/code/Magento/Cms/Model/ResourceModel/Page/Collection.php @@ -51,34 +51,6 @@ protected function _construct() $this->_map['fields']['store'] = 'store_table.store_id'; } - /** - * Returns pairs identifier - title for unique identifiers - * and pairs identifier|page_id - title for non-unique after first - * - * @return array - */ - public function toOptionIdArray() - { - $res = []; - $existingIdentifiers = []; - foreach ($this as $item) { - $identifier = $item->getData('identifier'); - - $data['value'] = $identifier; - $data['label'] = $item->getData('title'); - - if (in_array($identifier, $existingIdentifiers)) { - $data['value'] .= '|' . $item->getData('page_id'); - } else { - $existingIdentifiers[] = $identifier; - } - - $res[] = $data; - } - - return $res; - } - /** * Set first store flag * diff --git a/app/code/Magento/Cms/Test/Unit/Model/Config/Source/BlockTest.php b/app/code/Magento/Cms/Test/Unit/Model/Config/Source/BlockTest.php new file mode 100644 index 0000000000000..b6a91e9f56b30 --- /dev/null +++ b/app/code/Magento/Cms/Test/Unit/Model/Config/Source/BlockTest.php @@ -0,0 +1,66 @@ +collectionFactory = $this->createPartialMock( + \Magento\Cms\Model\ResourceModel\Block\CollectionFactory::class, + ['create'] + ); + + $this->block = $objectManager->getObject( + \Magento\Cms\Model\Config\Source\Block::class, + [ + 'collectionFactory' => $this->collectionFactory, + ] + ); + } + + /** + * Run test toOptionArray method + * + * @return void + */ + public function testToOptionArray() + { + $blockCollectionMock = $this->createMock(\Magento\Cms\Model\ResourceModel\Block\Collection::class); + + $this->collectionFactory->expects($this->once()) + ->method('create') + ->will($this->returnValue($blockCollectionMock)); + + $blockCollectionMock->expects($this->once()) + ->method('toOptionIdArray') + ->will($this->returnValue('return-value')); + + $this->assertEquals('return-value', $this->block->toOptionArray()); + } +}