From 0bba9324c2671f1957e848b6691509187d25d33c Mon Sep 17 00:00:00 2001 From: Anshu Mishra Date: Fri, 6 Jul 2018 17:20:06 +0530 Subject: [PATCH 1/4] Fixed issue : Trim whitespace on SKU when saving product #16572 --- .../Product/Initialization/Helper/AttributeFilter.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilter.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilter.php index abd8c2dd9f377..63e4c4aaaf0ee 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilter.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilter.php @@ -28,6 +28,9 @@ class AttributeFilter public function prepareProductAttributes(Product $product, array $productData, array $useDefaults): array { $attributeList = $product->getAttributes(); + + $productData['sku'] = trim($productData['sku']); + foreach ($productData as $attributeCode => $attributeValue) { if ($this->isAttributeShouldNotBeUpdated($product, $useDefaults, $attributeCode, $attributeValue)) { unset($productData[$attributeCode]); From cb1d7e77a03327576f01c5eba383760280bf95ee Mon Sep 17 00:00:00 2001 From: Anshu Mishra Date: Tue, 10 Jul 2018 18:27:56 +0530 Subject: [PATCH 2/4] Fix issue for configurable associated products --- .../ConfigurableProduct/Model/Product/VariationHandler.php | 1 + 1 file changed, 1 insertion(+) diff --git a/app/code/Magento/ConfigurableProduct/Model/Product/VariationHandler.php b/app/code/Magento/ConfigurableProduct/Model/Product/VariationHandler.php index a462a5ffd9edd..48d6ea922378b 100644 --- a/app/code/Magento/ConfigurableProduct/Model/Product/VariationHandler.php +++ b/app/code/Magento/ConfigurableProduct/Model/Product/VariationHandler.php @@ -92,6 +92,7 @@ public function generateSimpleProducts($parentProduct, $productsData) $productsData = $this->duplicateImagesForVariations($productsData); foreach ($productsData as $simpleProductData) { $newSimpleProduct = $this->productFactory->create(); + $simpleProductData['sku'] = trim($simpleProductData['sku']); if (isset($simpleProductData['configurable_attribute'])) { $configurableAttribute = json_decode($simpleProductData['configurable_attribute'], true); unset($simpleProductData['configurable_attribute']); From 75ae2a6a5ebff86f32574584ba79e1c0c60d9eb8 Mon Sep 17 00:00:00 2001 From: Anshu Mishra Date: Thu, 26 Jul 2018 17:43:52 +0530 Subject: [PATCH 3/4] trim configurations as per manual test review --- .../view/adminhtml/web/js/variations/steps/summary.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/variations/steps/summary.js b/app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/variations/steps/summary.js index dc83a58899981..f3bbdd2478ebc 100644 --- a/app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/variations/steps/summary.js +++ b/app/code/Magento/ConfigurableProduct/view/adminhtml/web/js/variations/steps/summary.js @@ -88,7 +88,7 @@ define([ * @param {Function} getSectionValue */ calculate: function (variations, getSectionValue) { - var productSku = this.variationsComponent().getProductValue('sku'), + var productSku = this.variationsComponent().getProductValue('sku').trim(), productPrice = this.variationsComponent().getProductPrice(), productWeight = this.variationsComponent().getProductValue('weight'), productName = this.variationsComponent().getProductValue('name'), From 002545c1f727fbd1979012be0fc2378bc301eb70 Mon Sep 17 00:00:00 2001 From: Anshu Mishra Date: Fri, 27 Jul 2018 10:49:38 +0530 Subject: [PATCH 4/4] remove whitespace --- .../Adminhtml/Product/Initialization/Helper/AttributeFilter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilter.php b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilter.php index 63e4c4aaaf0ee..ad2048e4f1665 100644 --- a/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilter.php +++ b/app/code/Magento/Catalog/Controller/Adminhtml/Product/Initialization/Helper/AttributeFilter.php @@ -28,7 +28,7 @@ class AttributeFilter public function prepareProductAttributes(Product $product, array $productData, array $useDefaults): array { $attributeList = $product->getAttributes(); - + $productData['sku'] = trim($productData['sku']); foreach ($productData as $attributeCode => $attributeValue) {