Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default storeview status field should be readonly not disabled #9976

Closed
codedge opened this issue Jun 18, 2017 · 6 comments
Closed

Default storeview status field should be readonly not disabled #9976

codedge opened this issue Jun 18, 2017 · 6 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@codedge
Copy link

codedge commented Jun 18, 2017

When trying to change the name of the default storeview, the first time you want to save your changes an error message occurs saying The default store cannot be disabled. That occurs as the status field is set to disabled instead of readonly and so the status field is not correctly submitted.

Preconditions

  • Magento CE 2.1.7
  • No test data installed, almost plain vanilla install

Steps to reproduce

  1. Go to Stores > All stores
  2. Click the default store view and change the name
  3. Submit you changes

Expected result

  1. Your changes should be saved without any errors.

Actual result

  1. An error occured The default store cannot be disabled

storeview_1

storeview_2

@korostii
Copy link
Contributor

Seems like a duplicate of #7349 and #6435. The bug has two internal tickets MAGETWO-60746 and MAGETWO-57979 for more than half a year.

So here's a little joke: how many developers do you need in order to change an attribute on a html input?

@magento-team, any feedback on this one?

@codedge
Copy link
Author

codedge commented Jun 20, 2017

Oh, I did look for an existing ticket but wasn't able to find one.
Would it help if I create a PR @magento-team?

@orlangur
Copy link
Contributor

@codedge PR would never hurt, at least as help for others to patch their Magento instance, and nowadays PRs are also processed pretty quickly.

@magento-engcom-team magento-engcom-team added G1 Passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@krisdante
Copy link
Contributor

I tried to reproduce on develop branch (e649b4c) and it is not reproducible anymore. Seems to be fixed in newest code.

@ishakhsuvarov
Copy link
Contributor

@krisdante Looks like fix was delivered to the develop branch (commits) and is going to be released with 2.2. However, issue is still likely to affect 2.1.

@magento-engcom-team
Copy link
Contributor

@codedge, thank you for your report.
The issue is already fixed in 2.2.0

@magento-engcom-team magento-engcom-team added Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

6 participants