Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta description allows too many characters #6238

Closed
Ctucker9233 opened this issue Aug 18, 2016 · 11 comments
Closed

Meta description allows too many characters #6238

Ctucker9233 opened this issue Aug 18, 2016 · 11 comments
Assignees
@lewisvoncken
Labels
Area: Frontend bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Ctucker9233
Copy link

I'm noticing that my magento setup is allowing any number of characters in the meta description field. It used to automatically cut off the description if I exceeded the maximum amount of characters while typing. Now, it allows any amount and only cuts it off after saving the product.

Preconditions

Magento 2.1.0
PHP 5.6.22
Upgraded From Magento 2.0.7

Steps to reproduce

  1. Create a new product (type of product doesn't seem to matter)
  2. Fill in meta description.
  3. Save

Expected result

  1. Meta description automatically cuts off the characters if character limit is exceeded before save.

Actual result

  1. Meta description allows the number of characters to exceed the limit and only cuts off the extra characters on save. See screenshots.

Pre-save
pre save

post-save
post save
@sevos1984 sevos1984 added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 26, 2016
@sevos1984
Copy link
Contributor

This is a known issue MAGETWO-3254. Thanks for posting

@Ctucker9233
Copy link
Author

@sevos1984 Wow! Judging by the magetwo number it's a pretty old known issue. Are we close to a fix?

@sevos1984
Copy link
Contributor

Yep, old one, but it has low priority. Not sure it will be fixed soon.

@Ctucker9233
Copy link
Author

@sevos1984 Man, too bad. It creates a lot of extra work having to go in, tweak the meta description, save, then go back and check. Then repeat as necessary.

@maderlock
Copy link

It's an easy fix - just add maxlength="255" (or whatever the maximum is) to the textarea. So it's odd that this has not been fixed as low hanging fruit.

@Ctucker9233
Copy link
Author

@maderlock what file and line does this code go in?

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Area: Frontend Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 6, 2017
@magento-engcom-team
Copy link
Contributor

@Ctucker9233, thank you for your report.
We've created internal ticket(s) MAGETWO-3254 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 6, 2017
@lewisvoncken
Copy link
Contributor

@magento-engcom-team pull request has been created in the partner github
https://github.com/magento-partners/magento2ce/pull/61

@lewisvoncken
Copy link
Contributor

I'm working on it #SQUASHTOBERFEST

This was referenced Oct 31, 2017
Merged
Closed
@okorshenko
Copy link
Contributor

The issue has been fixed in 2.2-develop branch and will be available with 2.2.2 release

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 10, 2017
@Ctucker9233
Copy link
Author

@okorshenko Great! When will the fix be backported to 2.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lewisvoncken lewisvoncken

Labels
Area: Frontend bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@maderlock @veloraven @lewisvoncken @okorshenko @vkorotun @sevos1984 @Ctucker9233 @magento-engcom-team