-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.1] "none" is not meant to be translated? #5886
Comments
👍 Experienced this as well |
We had the same issue. Should be removed
from this layout file: As temporary solution we can extend
|
@rasmuswikman issue is fixed in the latest develop |
@vrann Are the commit references? |
@Ctucker9233 this is the PR #6257 |
You seem to have forgotten to push this commit to the 2.1 branch. See https://github.com/magento/magento2/blob/2.1-develop/app/code/Magento/Catalog/view/frontend/layout/catalog_product_view.xml |
@vrann Seeing this in Magento 2.1.8 also. Can we reopen this issue to keep track? |
If one translates the word "none" to anything else, the product page attribute titles are printed although they should be hidden, because of the following line of code:
<?php if ($_attributeLabel != 'none'): ?>
.https://github.com/magento/magento2/blob/2.1/app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml#L37
Preconditions
Steps to reproduce
Expected result
Actual result
The text was updated successfully, but these errors were encountered: