Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1] "none" is not meant to be translated? #5886

Closed
ghost opened this issue Jul 29, 2016 · 8 comments
Closed

[2.1] "none" is not meant to be translated? #5886

ghost opened this issue Jul 29, 2016 · 8 comments
Labels
bug report Component: Catalog Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@ghost
Copy link

ghost commented Jul 29, 2016

If one translates the word "none" to anything else, the product page attribute titles are printed although they should be hidden, because of the following line of code: <?php if ($_attributeLabel != 'none'): ?>.

https://github.com/magento/magento2/blob/2.1/app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml#L37

Preconditions

  1. Magento 2.1

Steps to reproduce

  1. Translate the word "none" to anything else

Expected result

  1. Product attribute title should not be visible

Actual result

  1. Product attribute title is visible and shows the translated version of "none"
@paales
Copy link
Contributor

paales commented Jul 29, 2016

👍 Experienced this as well

@azanelli
Copy link
Contributor

We had the same issue.

Should be removed translate="true" in:

<argument name="at_label" translate="true" xsi:type="string">none</argument>

from this layout file: app/code/Magento/Catalog/view/frontend/layout/catalog_product_view.xml.


As temporary solution we can extend catalog_product_view.xml and add this:

<referenceBlock name="product.info.overview">
  <arguments>
    <argument name="at_label" xsi:type="string">none</argument>
  </arguments>
</referenceBlock>

@vrann
Copy link
Contributor

vrann commented Mar 14, 2017

@rasmuswikman issue is fixed in the latest develop

@vrann vrann closed this as completed Mar 14, 2017
@Ctucker9233
Copy link

@vrann Are the commit references?

@vrann
Copy link
Contributor

vrann commented Mar 15, 2017

@Ctucker9233 this is the PR #6257

@mkor
Copy link

mkor commented Jul 11, 2017

You seem to have forgotten to push this commit to the 2.1 branch.
Since the bug still occurs in Magento 2.1.7, can you push it there as well?

See https://github.com/magento/magento2/blob/2.1-develop/app/code/Magento/Catalog/view/frontend/layout/catalog_product_view.xml
and https://github.com/magento/magento2/blob/2.1.8-preview/app/code/Magento/Catalog/view/frontend/layout/catalog_product_view.xml

@ruudboon
Copy link

@vrann Seeing this in Magento 2.1.8 also. Can we reopen this issue to keep track?

@magento-engcom-team magento-engcom-team added 2.1.x bug report Component: Catalog Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Sep 11, 2017
@orlangur
Copy link
Contributor

@ruudboon tracked as #10738.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Catalog Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

10 participants