Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Add support for multiple space-separated CDATA sections in Magento\Framework\Xml\Parser #29613

Closed
4 tasks
m2-assistant bot opened this issue Aug 17, 2020 · 1 comment
Labels
Component: Xml Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.4 Indicates original Magento version for the Issue report. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. stale issue

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2020

This issue is automatically created based on existing pull request: #26822: Add support for multiple space-separated CDATA sections in Magento\Framework\Xml\Parser


Description (*)

Our XML files sometimes contain multiple CDATA sections per node. The XML parser class provided by Magento in /lib/internal/Magento/Framework/Xml/Parser.php already supports consecutive CDATA sections like <![CDATA[One]]><![CDATA[Two]]><![CDATA[Three]]>, which is correctly parsed as OneTwoThree. However this returns wrong results for empty text nodes in-between, like for <![CDATA[One]]> <![CDATA[Two]]> <![CDATA[Three]]>. This pull request adds the support and a related unit test.

Related Pull Requests

The switch statement has been added in #681.

Fixed Issues (if relevant)

No separate issue created.

Manual testing scenarios (*)

Unit tests added as part of this pull request.

You can use the current 2.3.4 version for testing. The file in question /lib/internal/Magento/Framework/Xml/Parser.php is unchanged since August 2017.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Xml Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 17, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR in progress labels Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: ready for dev and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Nov 11, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.4 Indicates original Magento version for the Issue report. label Nov 13, 2020
@stale
Copy link

stale bot commented Jan 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Xml Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.4 Indicates original Magento version for the Issue report. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. stale issue
Projects
2 participants