Product AdditionalOptions "Read more" dots being escaped on invoice/shipment overview pages

[itmsenior]

Preconditions (*)

1. Magento 2.3.2
2. Product with additionalOptions populated

Steps to reproduce (*)

1. Create a product that includes an additionalOption value that is over 55 characters
2. Place order for product
3. View invoice for order in customer dashboard

Expected result (*)

1. Product additional options appear with ".." and tooltip with full message

Actual result (*)

1. Options are escaped causing html to show:
   

It's caused by the following commit: f15f42d#diff-fac9e3967557f4a64daadb9e587360d1

Line: escapeHtml($_formatedOptionValue['value']) ?>

I appreciate it's a security fix, but the core code shouldn't be adding HTML in the ItemRenderer then escaping it in a template file.

[m2-assistant]

Hi @itwebdev2. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@itwebdev2 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[ajijshekh123]

Give me @magento give me 2.3-develop instance

[magento-engcom-team]

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @ajijshekh123, here is your Magento instance.
Admin access: https://i-25050-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[ajijshekh123]

I have not reproduced this issue.
Steps:

1. In the Admin section > Create a simple product with additional product details.
2. In the front end section > Place one Order with selected additional product option.
3. In the Admin section > Generate Invoice > Review the Invoice in front end view.

Actual result: Text is displayed properly

See attached screenshot:

@itwebdev2 - Give me proper details and screenshot if you have found this issue again. Which version you have used please update me.

[itmsenior]

I have not reproduced this issue.
Steps:

1. In the Admin section > Create a simple product with additional product details.
2. In the front end section > Place one Order with selected additional product option.
3. In the Admin section > Generate Invoice > Review the Invoice in front end view.

Actual result: Text is displayed properly

See attached screenshot:

@itwebdev2 - Give me proper details and screenshot if you have found this issue again. Which version you have used please update me.

You've made the title really long but the actual content is only "test1". Could you please do another test but make the actual content of the additionalOption longer than 55 characters?

[itmsenior]

@ajijshekh123 could you please review my comment above?

[ajijshekh123]

@itwebdev2 - Sorry for the late response. Today I will review this issue again update it.

[ajijshekh123]

Give me @magento give me 2.3-develop instance

[magento-engcom-team]

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @ajijshekh123, here is your Magento instance.
Admin access: https://i-25050-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[ajijshekh123]

The issue has been reproduced as defined by the steps and details.
@itwebdev2 - Thanks for the Update.
See attached screenshot:

[magento-engcom-team]

@ajijshekh123 Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

• Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

[magento-engcom-team]

✅ Confirmed by @ajijshekh123
Thank you for verifying the issue. Based on the provided information internal tickets MC-22022 were created

Issue Available: @ajijshekh123, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[m2-assistant]

Hi @torhoehn. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[VladimirZaets]

Hi @itwebdev2. Thank you for your report.
The issue has been fixed in #25418 by @torhoehn in 2.3-develop branch
Related commit(s):

• e42294213f19f3f8240e91c7299aeebf1a21e16c
• 4b432f8f0600cda910a4e8752422565ec6838f02
• d4cae504fba92e4f0001a665d6b2ef02368d7650
• 6e36d5e605e07d3a0f773de1a98884f75430aaf5

The fix will be available with the upcoming 2.3.5 release.