-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Issue "vertex tax classes" #15463
Comments
I have to agree with @SamB-GB here. That Vertex module completely overwrites 3 default Magento system config fields and blatantly puts their own branding on top of it. Wth? Did someone from Magento actually review this module before this got included by default??? System config fields it overwrites:
|
FYI if you are using
This will remove after But I agree that some strange modules have been included in |
@elvinristi : Thanks for your trick to avoid having these modules. I just wanted to add, that the "Vertex" Module is not compatible with PHP7.0. Refer here for details: |
Hi, thanks for this report! This is something we overlooked when we moved from a standalone module to a bundled extension. We have this in our backlog now and you should expect it fixed in Vertex Tax Links for Magento 2, v2.1.10 and above, which we plan to have included in Magento 2.2.6 Internal Ticket VRTX-334 |
@SamB-GB Unfortunately, we are closing this ticket, as it does not relate to the code published in the |
@magento-engcom-team , why you have then included in your package vertex/module-tax if you haven't even tested this and don't take responsibility to make sure that code gets fixed and release ASAP correct one and we need instead come up hacks to remove the module? |
@elvinristi thanks for the composer solution, that really helps. This is already the 4th non-magento module that contains critical bugs. |
@mariamghalleb Can you confirm that the composer package This is an error I've not seen before. Please also include information such as your version of PHP, the version of vertex/module-tax installed (check vendor/vertex/module-tax/composer.json) and the version of Magento installed |
Having started setting up a new Magento 2.2.4 the TAX calculations where off for shipping but I wasn't able to fix the issue. I searched Google and lots of places where pointing to setting the correct tax Class for shipping but I wasn't able to find this setting UNTIL I found it in Stores > Configuration > Sales > Tax > Vertex Tax Classes
Changing these settings changed the calculation despite the fact I am not using Vertex so you may want to re-word that back to Tax Classes
Preconditions
Actual result
The text was updated successfully, but these errors were encountered: