-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String class name issue for php7 #1367
Comments
Yes, there are a few similar class named we hit when we tried php 7 as well. Good news was there were not many that needed to be renamed to get php to work. (I don't recall where that got to on the backlog.) |
PHP7 is not supported yet: https://github.com/magento/magento2/blob/develop/composer.json#L11 There are more reserved words which needs to be considered: http://php.net/manual/en/reserved.other-reserved-words.php The most frequently used in code base is |
Internal ticket: MAGETWO-37817 |
Just for reference, a quick scan for classes w/ newly reserved words as names:
|
@vpelipenko Any chance you will also be fixing Magento 1.9?
Source - http://afilina.com/magento-1-9-on-php7/ Also I am unable to login to /admin |
@craigcarnell, probably yes, but I don't know when. |
Adaptation of code to PHP7 was done and all changes are available in develop branch. Please, try this. If you have any question or face with new issues, please, let us know. |
Had an interesting folder conflict that loaded the old version. New one seems to be running so far, will test more once I get a nice environment scripted. |
@dccampbell, there is no |
Fixed a nginx/php-fpm permissions conflict. Running all green now. |
In case this helps anybody w/ testing, I've made my Vagrant setup available: Tested smooth on Ubuntu14 and Win7 hosts. So far no issues to report, though I'm holding out for a new sample data version that's usable with the current develop branch to really test it hard. |
I created an issue on Magento 1 bug tracker.. http://www.magentocommerce.com/bug-tracking/issue/index/id/994 Since the search feature does not work.. I'm not sure if anyone else appeared to report it. Also the whole system is susceptible for XSS by placing javascript in the comments section.. just so you know. |
No issues so far on the new PHP7 RC, although still waiting on sample data support to make a more thorough pass. |
@dccampbell it works for us now. Please reopen the ticket if you still have this problem. |
When is this available for the merchant beta? |
I'm assuming this is all ready in https://github.com/magento/magento2/releases/tag/1.0.0-beta4 |
Of note, as of 1.0.0-beta4 the composer.json is still restricted to PHP ~5.5.0|~5.6.0. |
I'm using the merchant beta and PHP 7 is not working |
the merchant beta tag is an older snapshot -- you'll need to use the |
MAGETWO-70790: Cannot remove custom option
Fatal error: Cannot use 'String' as class name as it is reserved in lib/internal/Magento/Framework/Data/Argument/Interpreter/String.php on line 14
The text was updated successfully, but these errors were encountered: