Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer navigation showing wrong product count #11946

Closed
sunilit42 opened this issue Nov 2, 2017 · 9 comments
Closed

Layer navigation showing wrong product count #11946

sunilit42 opened this issue Nov 2, 2017 · 9 comments
Assignees
@RomaKis
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@sunilit42
Copy link
Contributor

Preconditions

Magento version 2.1.9
Enable out of stock display yes from backend

Getting errors -
Layer navigation count wrong due to Magento count only in-stock product.
https://github.com/magento/magento2/blob/2.1.9/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Aggregation/DataProvider.php#L115

Actual result:
count calculation based on backend stock setting.
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Nov 2, 2017
@sunilit42
Copy link
Contributor Author

It is also same for magento 2.2 version.

@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Nov 2, 2017
@magento-engcom-team
Copy link
Contributor

@sunilit42, thank you for your report.
We've created internal ticket(s) MAGETWO-81624 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 2, 2017
@sunilit42 sunilit42 changed the title Layer navigation showing product count Layer navigation showing wrong product count Nov 2, 2017
@j-plou
Copy link

j-plou commented Nov 4, 2017

@sunilit42 Can't reproduce it in 2.2. Could you attach any screenshot or more details/steps on how to reproduce it?

@RomaKis RomaKis self-assigned this Nov 6, 2017
@sunilit42
Copy link
Contributor Author

Hello,
Case 1) Go to Backend set Out of stock display No (Make sure some product out of stock)
Go to any category , check count of layer navigation of attribute

Case 2) Go to Backend set Out of stock display Yes
Go to any category , check count of layer navigation of attribute, it will show same

It does not count out of stock product count into layer nav.

Check below file

https://github.com/magento/magento2/blob/2.2.0/app/code/Magento/CatalogSearch/Model/Adapter/Mysql/Aggregation/DataProvider.php#L117

@RomaKis RomaKis mentioned this issue Nov 6, 2017
Merged
4 tasks
@versdivers
Copy link

Still an issue 9/12/2017 magento 2,2,1

@ishakhsuvarov
Copy link
Contributor

Hi @sunilit42 @versdivers
We are closing this issue now as the fix has been delivered with the commit 3839c0f and should be released with 2.2.4
Thank you.

@ishakhsuvarov ishakhsuvarov added Fixed in 2.2.x The issue has been fixed in 2.2 release line and removed 2.1.x labels Dec 13, 2017
@p-bystritsky p-bystritsky mentioned this issue Dec 27, 2017
Closed
@magento-engcom-team
Copy link
Contributor

Hi @sunilit42. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1297 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 27, 2018
@saiwingwu
Copy link

When could this fix be backported to 2.1.14?

@Wadekone
Copy link

Wadekone commented Sep 5, 2019

@magento-engcom-team

  1. magento-engcom/magento2ce#1297 takes to 404. Any working link?
  2. Any backport for Commerce edition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomaKis RomaKis

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@sunilit42 @ishakhsuvarov @Wadekone @j-plou @RomaKis @versdivers @saiwingwu @magento-engcom-team