getLogger() is now private so the internal logger is not exposed in LoggerProxy. Unit test modified accordingly.

Author: federivo

Diff for: lib/internal/Magento/Framework/DB/Logger/LoggerProxy.php

@@ -108,9 +108,9 @@ public function __construct(
      * Get logger object. Initialize if needed.
      * @return LoggerInterface
      */
-    public function getLogger()
+    private function getLogger()
     {
-        if($this->logger === null) {
+        if ($this->logger === null) {
             switch ($this->loggerAlias) {
                 case self::LOGGER_ALIAS_FILE:
                     $this->logger = $this->fileFactory->create(

Diff for: lib/internal/Magento/Framework/DB/Test/Unit/DB/Logger/LoggerProxyTest.php

@@ -42,6 +42,9 @@ public function testNewWithAliasFile()
             ->disableOriginalConstructor()
             ->getMock();
 
+        $fileLoggerMock->expects($this->once())
+            ->method('log');
+
         $fileLoggerFactoryMock = $this->getMockBuilder(FileFactory::class)
             ->disableOriginalConstructor()
             ->setMethods(['create'])
@@ -51,26 +54,54 @@ public function testNewWithAliasFile()
             ->method('create')
             ->willReturn($fileLoggerMock);
 
+        $quietLoggerMock = $this->getMockBuilder(Quiet::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $quietLoggerMock->expects($this->never())
+            ->method('log');
+
+        $quietLoggerFactoryMock = $this->getMockBuilder(QuietFactory::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['create'])
+            ->getMock();
+
         $this->loggerProxy = $this->objectManager->getObject(
             LoggerProxy::class,
             [
                 'fileFactory' => $fileLoggerFactoryMock,
+                'quietFactory' => $quietLoggerFactoryMock,
                 'loggerAlias' => LoggerProxy::LOGGER_ALIAS_FILE,
             ]
         );
 
-        $this->assertInstanceOf(File::class, $this->loggerProxy->getLogger());
+        $this->loggerProxy->log('test');
     }
 
     /**
      * Test new logger proxy with disabled alias
      */
     public function testNewWithAliasDisabled()
     {
+        $fileLoggerMock = $this->getMockBuilder(File::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $fileLoggerMock->expects($this->never())
+            ->method('log');
+
+        $fileLoggerFactoryMock = $this->getMockBuilder(FileFactory::class)
+            ->disableOriginalConstructor()
+            ->setMethods(['create'])
+            ->getMock();
+
         $quietLoggerMock = $this->getMockBuilder(Quiet::class)
             ->disableOriginalConstructor()
             ->getMock();
 
+        $quietLoggerMock->expects($this->once())
+            ->method('log');
+
         $quietLoggerFactoryMock = $this->getMockBuilder(QuietFactory::class)
             ->disableOriginalConstructor()
             ->setMethods(['create'])
@@ -83,11 +114,12 @@ public function testNewWithAliasDisabled()
         $this->loggerProxy = $this->objectManager->getObject(
             LoggerProxy::class,
             [
+                'fileFactory' => $fileLoggerFactoryMock,
                 'quietFactory' => $quietLoggerFactoryMock,
                 'loggerAlias' => LoggerProxy::LOGGER_ALIAS_DISABLED,
             ]
         );
 
-        $this->assertInstanceOf(Quiet::class, $this->loggerProxy->getLogger());
+        $this->loggerProxy->log('test');
     }
 }