Skip to content

Commit 7704429

Browse files
committed
MAGETWO-52000: [Github][PR]impossible to see what is wrong with cron - unhelpful error message #3189
- Code update to fix QA issues
1 parent 8270c85 commit 7704429

File tree

1 file changed

+4
-32
lines changed

1 file changed

+4
-32
lines changed

Diff for: setup/src/Magento/Setup/Model/Cron/SetupLoggerFactory.php

+4-32
Original file line numberDiff line numberDiff line change
@@ -6,51 +6,23 @@
66

77
namespace Magento\Setup\Model\Cron;
88

9-
use Magento\Setup\Model\ObjectManagerProvider;
10-
119
/**
1210
* Class to get PSR-3 compliant logger instance
1311
*/
1412
class SetupLoggerFactory
1513
{
16-
/**
17-
* @var ObjectManagerProvider
18-
*/
19-
private $objectManagerProvider;
20-
21-
/**
22-
* @var SetupStreamHandler
23-
*/
24-
private $setupStreamHandler;
25-
26-
/**
27-
* Constructor
28-
*
29-
* @param ObjectManagerProvider $objectManagerProvider
30-
* @param SetupStreamHandler $setupStreamHandler
31-
*/
32-
public function __construct(
33-
ObjectManagerProvider $objectManagerProvider,
34-
SetupStreamHandler $setupStreamHandler
35-
) {
36-
$this->objectManagerProvider = $objectManagerProvider;
37-
$this->setupStreamHandler = $setupStreamHandler;
38-
}
39-
4014
/**
4115
* Create logger instance.
4216
*
4317
* @param string $channelName
4418
*
4519
* @return \Psr\Log\LoggerInterface
4620
*/
47-
public function create($channelName)
21+
public function create($channelName = 'setup-cron')
4822
{
49-
/** @var \Magento\Framework\Logger\Monolog $logger */
50-
$logger = $this->objectManagerProvider
51-
->get()
52-
->create('Magento\Framework\Logger\Monolog', ['name' => $channelName]);
53-
$logger->pushHandler($this->setupStreamHandler);
23+
$logger = new \Monolog\Logger($channelName);
24+
$path = BP . '/var/log/update.log';
25+
$logger->pushHandler(new \Monolog\Handler\StreamHandler($path));
5426
return $logger;
5527
}
5628
}

0 commit comments

Comments
 (0)