Skip to content

Commit 4c6636d

Browse files
authored
Merge pull request #6536 from magento-tsg/MC-23915
[Arrows] MC-23915: Revert 23915 because it caused static tests failure
2 parents fb2f1a7 + 152b41b commit 4c6636d

File tree

6 files changed

+4
-152
lines changed

6 files changed

+4
-152
lines changed

Diff for: app/code/Magento/Sales/Model/ResourceModel/Order/Creditmemo/Grid/Collection.php

-28
Original file line numberDiff line numberDiff line change
@@ -33,32 +33,4 @@ public function __construct(
3333
) {
3434
parent::__construct($entityFactory, $logger, $fetchStrategy, $eventManager, $mainTable, $resourceModel);
3535
}
36-
37-
/**
38-
* @inheritDoc
39-
*/
40-
protected function _translateCondition($field, $condition)
41-
{
42-
if ($field !== 'order_currency_code'
43-
&& !isset($this->_map['fields'][$field])
44-
) {
45-
$this->_map['fields'][$field] = 'main_table.' . $field;
46-
}
47-
48-
return parent::_translateCondition($field, $condition);
49-
}
50-
51-
/**
52-
* @inheritDoc
53-
*/
54-
protected function _renderFiltersBefore()
55-
{
56-
$this->getSelect()->joinLeft(
57-
['cgf' => $this->getTable('sales_order_grid')],
58-
'main_table.order_id = cgf.entity_id',
59-
[
60-
'order_currency_code' => 'order_currency_code',
61-
]
62-
);
63-
}
6436
}

Diff for: app/code/Magento/Sales/Model/ResourceModel/Order/Creditmemo/Order/Grid/Collection.php

-28
Original file line numberDiff line numberDiff line change
@@ -33,32 +33,4 @@ public function __construct(
3333
) {
3434
parent::__construct($entityFactory, $logger, $fetchStrategy, $eventManager, $mainTable, $resourceModel);
3535
}
36-
37-
/**
38-
* @inheritDoc
39-
*/
40-
protected function _translateCondition($field, $condition)
41-
{
42-
if ($field !== 'order_currency_code'
43-
&& !isset($this->_map['fields'][$field])
44-
) {
45-
$this->_map['fields'][$field] = 'main_table.' . $field;
46-
}
47-
48-
return parent::_translateCondition($field, $condition);
49-
}
50-
51-
/**
52-
* @inheritDoc
53-
*/
54-
protected function _renderFiltersBefore()
55-
{
56-
$this->getSelect()->joinLeft(
57-
['cgf' => $this->getTable('sales_order_grid')],
58-
'main_table.order_id = cgf.entity_id',
59-
[
60-
'order_currency_code' => 'order_currency_code',
61-
]
62-
);
63-
}
6436
}

Diff for: app/code/Magento/Sales/view/adminhtml/ui_component/sales_order_creditmemo_grid.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -194,14 +194,14 @@
194194
<visible>false</visible>
195195
</settings>
196196
</column>
197-
<column name="subtotal" class="Magento\Sales\Ui\Component\Listing\Column\PurchasedPrice">
197+
<column name="subtotal" class="Magento\Sales\Ui\Component\Listing\Column\Price">
198198
<settings>
199199
<filter>textRange</filter>
200200
<label translate="true">Subtotal</label>
201201
<visible>false</visible>
202202
</settings>
203203
</column>
204-
<column name="shipping_and_handling" class="Magento\Sales\Ui\Component\Listing\Column\PurchasedPrice">
204+
<column name="shipping_and_handling" class="Magento\Sales\Ui\Component\Listing\Column\Price">
205205
<settings>
206206
<filter>textRange</filter>
207207
<label translate="true">Shipping &amp; Handling</label>

Diff for: app/code/Magento/Sales/view/adminhtml/ui_component/sales_order_view_creditmemo_grid.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -207,14 +207,14 @@
207207
<visible>false</visible>
208208
</settings>
209209
</column>
210-
<column name="subtotal" class="Magento\Sales\Ui\Component\Listing\Column\PurchasedPrice">
210+
<column name="subtotal" class="Magento\Sales\Ui\Component\Listing\Column\Price">
211211
<settings>
212212
<filter>textRange</filter>
213213
<label translate="true">Subtotal</label>
214214
<visible>false</visible>
215215
</settings>
216216
</column>
217-
<column name="shipping_and_handling" class="Magento\Sales\Ui\Component\Listing\Column\PurchasedPrice">
217+
<column name="shipping_and_handling" class="Magento\Sales\Ui\Component\Listing\Column\Price">
218218
<settings>
219219
<filter>textRange</filter>
220220
<label translate="true">Shipping &amp; Handling</label>

Diff for: dev/tests/integration/testsuite/Magento/Sales/Model/ResourceModel/Order/Creditmemo/Grid/CollectionTest.php

-46
This file was deleted.

Diff for: dev/tests/integration/testsuite/Magento/Sales/Model/ResourceModel/Order/Creditmemo/Order/Grid/CollectionTest.php

-46
This file was deleted.

0 commit comments

Comments
 (0)