MAGETWO-53293: Remove PHP 5.5 from supported versions

- added call to array_values method before ... operator to prevent fatal error "Fatal error: Uncaught Error: Cannot unpack array with string keys"

Author: Volodymyr Kublytskyi

Diff for: app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/Product/Type/OptionTest.php

@@ -289,7 +289,7 @@ protected function setUp()
         ];
 
         $modelClassName = \Magento\CatalogImportExport\Model\Import\Product\Option::class;
-        $this->model = new $modelClassName(...$modelClassArgs);
+        $this->model = new $modelClassName(...array_values($modelClassArgs));
         // Create model mock with rewritten _getMultiRowFormat method to support test data with the old format.
         $this->modelMock = $this->getMockBuilder($modelClassName)
             ->setConstructorArgs($modelClassArgs)

Diff for: app/code/Magento/Quote/Model/ShippingAddressManagement.php

@@ -97,6 +97,10 @@ public function assign($cartId, \Magento\Quote\Api\Data\AddressInterface $addres
         $quote->setShippingAddress($address);
         $address = $quote->getShippingAddress();
 
+        if ($customerAddressId === null) {
+            $address->setCustomerAddressId(null);
+        }
+
         if ($customerAddressId) {
             $addressData = $this->addressRepository->getById($customerAddressId);
             $address = $quote->getShippingAddress()->importCustomerAddressData($addressData);

Diff for: lib/internal/Magento/Framework/Filter/Input.php

@@ -344,7 +344,7 @@ protected function _createNativeZendFilter($filterData)
         if (is_string($filter)) {
             $filterClassName = 'Zend_Filter_' . ucfirst($filter);
             $filterClassOptions = isset($filterData['args']) ? $filterData['args'] : [];
-            $filter = new $filterClassName(...$filterClassOptions);
+            $filter = new $filterClassName(...array_values($filterClassOptions));
         }
 
         if (!$filter instanceof \Zend_Filter_Interface) {

Diff for: lib/internal/Magento/Framework/Interception/Chain/Chain.php

@@ -49,7 +49,7 @@ public function invokeNext(
             foreach ($pluginInfo[DefinitionInterface::LISTENER_BEFORE] as $code) {
                 $pluginInstance = $this->pluginList->getPlugin($type, $code);
                 $pluginMethod = 'before' . $capMethod;
-                $beforeResult = $pluginInstance->$pluginMethod($subject, ...$arguments);
+                $beforeResult = $pluginInstance->$pluginMethod($subject, ...array_values($arguments));
                 if ($beforeResult) {
                     $arguments = $beforeResult;
                 }
@@ -64,7 +64,7 @@ public function invokeNext(
             };
             $pluginInstance = $this->pluginList->getPlugin($type, $code);
             $pluginMethod = 'around' . $capMethod;
-            $result = $pluginInstance->$pluginMethod($subject, $next, ...$arguments);
+            $result = $pluginInstance->$pluginMethod($subject, $next, ...array_values($arguments));
             unset($pluginInstance, $pluginMethod);
         } else {
             $result = $subject->___callParent($method, $arguments);

Diff for: lib/internal/Magento/Framework/Interception/Interceptor.php

@@ -71,7 +71,7 @@ public function ___init()
      */
     public function ___callParent($method, array $arguments)
     {
-        return parent::$method(...$arguments);
+        return parent::$method(...array_values($arguments));
     }
 
     /**
@@ -120,7 +120,7 @@ protected function ___callPlugins($method, array $arguments, array $pluginInfo)
             foreach ($pluginInfo[DefinitionInterface::LISTENER_BEFORE] as $code) {
                 $pluginInstance = $this->pluginList->getPlugin($this->subjectType, $code);
                 $pluginMethod = 'before' . $capMethod;
-                $beforeResult = $pluginInstance->$pluginMethod($this, ...$arguments);
+                $beforeResult = $pluginInstance->$pluginMethod($this, ...array_values($arguments));
                 if ($beforeResult) {
                     $arguments = $beforeResult;
                 }
@@ -139,11 +139,11 @@ protected function ___callPlugins($method, array $arguments, array $pluginInfo)
             };
             $pluginInstance = $this->pluginList->getPlugin($this->subjectType, $code);
             $pluginMethod = 'around' . $capMethod;
-            $result = $pluginInstance->$pluginMethod($this, $next, ...$arguments);
+            $result = $pluginInstance->$pluginMethod($this, $next, ...array_values($arguments));
             unset($pluginInstance, $pluginMethod);
         } else {
             // Call original method
-            $result = parent::$method(...$arguments);
+            $result = parent::$method(...array_values($arguments));
         }
         if (isset($pluginInfo[DefinitionInterface::LISTENER_AFTER])) {
             // Call 'after' listeners

Diff for: lib/internal/Magento/Framework/ObjectManager/Factory/AbstractFactory.php

@@ -90,7 +90,7 @@ public function setArguments($arguments)
      */
     protected function createObject($type, $args)
     {
-        return new $type(...$args);
+        return new $type(...array_values($args));
     }
 
     /**

Diff for: lib/internal/Magento/Framework/TestFramework/Unit/Helper/ObjectManager.php

@@ -217,7 +217,7 @@ function ($className, $arguments) {
                                 }
                             }
                         }
-                        return new $className(...$args);
+                        return new $className(...array_values($args));
                     }
                 ));
 

Diff for: setup/src/Magento/Setup/Test/Unit/Module/I18n/Dictionary/PhraseTest.php

@@ -17,7 +17,7 @@ class PhraseTest extends \PHPUnit_Framework_TestCase
      */
     public function testPhraseCreation($constructArguments, $getter, $result)
     {
-        $phrase = new Phrase(...$constructArguments);
+        $phrase = new Phrase(...array_values($constructArguments));
         $this->assertEquals($result, $phrase->{$getter}());
     }
 
@@ -57,7 +57,7 @@ public function testWrongParametersWhilePhraseCreation($constructArguments, $mes
     {
         $this->setExpectedException('DomainException', $message);
 
-        new Phrase(...$constructArguments);
+        new Phrase(...array_values($constructArguments));
     }
 
     /**