MAGETWO-53713: [GITHUB] The time has come for splat operator #4766

- removed usage of class reflection for object instantiation in other places

Author: Volodymyr Kublytskyi

Diff for: app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/Product/Type/OptionTest.php

@@ -289,8 +289,7 @@ protected function setUp()
         ];
 
         $modelClassName = \Magento\CatalogImportExport\Model\Import\Product\Option::class;
-        $class = new \ReflectionClass($modelClassName);
-        $this->model = $class->newInstanceArgs($modelClassArgs);
+        $this->model = new $modelClassName(...$modelClassArgs);
         // Create model mock with rewritten _getMultiRowFormat method to support test data with the old format.
         $this->modelMock = $this->getMockBuilder($modelClassName)
             ->setConstructorArgs($modelClassArgs)

Diff for: lib/internal/Magento/Framework/Filter/Input.php

@@ -342,16 +342,13 @@ protected function _createNativeZendFilter($filterData)
     {
         $filter = $filterData['zend'];
         if (is_string($filter)) {
-            $class = new \ReflectionClass('Zend_Filter_' . $filter);
-            if ($class->implementsInterface('Zend_Filter_Interface')) {
-                if (isset($filterData['args']) && $class->hasMethod('__construct')) {
-                    $filter = $class->newInstanceArgs($filterData['args']);
-                } else {
-                    $filter = $class->newInstance();
-                }
-            } else {
-                throw new \Exception('Filter is not instance of \Zend_Filter_Interface');
-            }
+            $filterClassName = 'Zend_Filter_' . ucfirst($filter);
+            $filterClassOptions = isset($filterData['args']) ? $filterData['args'] : [];
+            $filter = new $filterClassName(...$filterClassOptions);
+        }
+        
+        if (!$filter instanceof \Zend_Filter_Interface) {
+            throw new \Exception('Filter is not instance of \Zend_Filter_Interface');
         }
         return $filter;
     }

Diff for: setup/src/Magento/Setup/Test/Unit/Module/I18n/Dictionary/PhraseTest.php

@@ -17,8 +17,7 @@ class PhraseTest extends \PHPUnit_Framework_TestCase
      */
     public function testPhraseCreation($constructArguments, $getter, $result)
     {
-        $reflectionClass = new \ReflectionClass('Magento\Setup\Module\I18n\Dictionary\Phrase');
-        $phrase = $reflectionClass->newInstanceArgs($constructArguments);
+        $phrase = new Phrase(...$constructArguments);
         $this->assertEquals($result, $phrase->{$getter}());
     }
 
@@ -58,8 +57,7 @@ public function testWrongParametersWhilePhraseCreation($constructArguments, $mes
     {
         $this->setExpectedException('DomainException', $message);
 
-        $reflectionClass = new \ReflectionClass('Magento\Setup\Module\I18n\Dictionary\Phrase');
-        $reflectionClass->newInstanceArgs($constructArguments);
+        new Phrase(...$constructArguments);
     }
 
     /**