Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--remove not triggered when peerflix exits because player was closed #331

Open
jrouleau opened this issue Nov 24, 2017 · 2 comments
Open

Comments

@jrouleau
Copy link

-r, --remove remove files on exit

When --remove is set, files should be removed regardless of how we exit.

Currently, engine.remove() is only triggered on SIGINT and SIGTERM and not when we exit after the player closes as we are directly calling process.exit(0) from the [player].on('exit') callbacks.

@mafintosh
Copy link
Owner

Yea that's a bug. Wanna pr?

@smallbrownbike
Copy link

Pending pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants