Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Here documents enclosed in backticks do not highlight comments correctly #17

Open
dnicolson opened this issue Apr 3, 2022 · 6 comments

Comments

@dnicolson
Copy link

Here documents that are enclosed in backticks do not properly handle the termination of comments:

PixelSnap 2022-04-03 at 18 56 02@2x

An example can be seen here:
https://github.com/autoconf-archive/autoconf-archive/blob/9b71386/m4/ax_python_devel.m4#L206

@maelvls
Copy link
Owner

maelvls commented Apr 3, 2022

Thanks for reporting the issue. Would you like to contribute a fix? That would be super helpful!!

@dnicolson
Copy link
Author

I had a look at the issue, I suspect it's specific to how Visual Studio Code does syntax highlighting as the issue is not present in Sublime Text with Sublime Autotools.

I compared the Autoconf.tmLanguage file with the original https://github.com/ptomato/sublime_autotools/blob/master/Autoconf.YAML-tmLanguage file after formatting with a YAML Formatter to make the diff easier.

If you have any idea of the cause of the issue it might be helpful.

@GitMensch
Copy link
Collaborator

Hm in general we have the following note in the README

I chose to fork the [sublime project][sublime_autotools] in order to have an easy way of updating vscode_autotools (which is only a matter of git merge).

So... shouldn't there be a merge from upstream after all these years? GH currently shows this extension is "20 commits behind" (I'd guess at least 10 are irrelevant, but I don't know if/how to tell git "ignore those revisions" and my general git "foo" is not that good, so @maelvls Could you please have a look at updating from upstream? This may solve this issue (or not, then it would still be useful).

@maelvls
Copy link
Owner

maelvls commented Mar 5, 2023

Hi! I finally found a bit of time and merged ptomato/master into my fork. I have released v0.2.0 on vscode's marketplace and Open VSX.

Unfortunately, the bug seems to still be here with v0.2.0:

Screenshot 2023-03-05 at 14 02 30

@GitMensch
Copy link
Collaborator

Actually the bug seems to be fixed, no? The old ` leaked into the following lines (the if in line 206 was seen as part of it) while your screenshot shows line 206 as new statement.

@dnicolson
Copy link
Author

It looks fixed here:
PixelSnap 2023-05-28 at 19 39 27@2x

The Python code is syntax highlighted though, which may be related to odd highlighting for AC_MSG_FAILURE text.
PixelSnap 2023-05-28 at 19 38 51@2x

In Sublime Text it looks normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants