issue with quoted comment marker

[GitMensch]

Some entries actual need an empty "on error do nothing" to override the default behavior (likely of stopping with an error).

A good sample is likely:

PKG_CHECK_MODULES([CJSON], [libcjson], [], [#])

this extension does not stop the inline comment and therefore assumes the macro parameters are not correctly closed, which makes editing all following lines bad (full of red errors and no option to match brackets correct)

[GitMensch]

Just wanted to note that this is still bugging me, I've tried to have a "more or less quick" look at the definition but neither "comment" nor "#" are good search criterias in the tmLanguage definition for autoconf. Any hint where to look at?
I think ] will always end a line # comment, but I have no clue where to add that rule.

[maelvls]

So sorry I didn't get to come back to you before :(

Could you try to open a PR with the change? I would greatly appreciate it!

[GitMensch]

I'd love to pull anything but I have no clue where to do the change. Help/hints wanted... (I could then investigate and test and PR)

[maelvls]

No problem! I added a bit of help in the readme if you want to check it out 😀

[maelvls]

Hmmm I think I know where the bug comes from... it does not seem to be due to the grammar itself (Autoconf.YAML-tmLanguage). I would guess it comes from how VSCode parses comments:

vscode_autotools/language-configuration.json

Lines 2 to 5 in dc6849f

	"comments": {
	// symbol used for single line comment. Remove this entry if your language does not support line comments
	"lineComment": "#"
	},

[maelvls]

Nope, doesn't look like an issue with language-configuration.json...

Works:

PKG_CHECK_MODULES([CJSON], [#])

Breaks:

PKG_CHECK_MODULES([CJSON], [], [#])

I'm clueless 🙁

[GitMensch]

Is this an upstream issue?