Fix NS_SWIFT_SENDABLE protocols not being Send + Sync

This is especially relevant for Xcode 26, because they mark a lot of
Metal APIs as sendable, and we would like that as well.
#762

Author: madsmtm

crates/header-translator/src/stmt.rs

@@ -2586,7 +2586,7 @@ impl Stmt {
                     availability,
                     super_protocols,
                     methods,
-                    required_sendable: _,
+                    required_sendable,
                     required_mainthreadonly,
                     documentation,
                 } => {
@@ -2611,15 +2611,14 @@ impl Stmt {
                             write!(f, "{}", protocol.id.path())?;
                         }
                     }
-                    // TODO
-                    // if *required_sendable {
-                    //     if protocols.is_empty() {
-                    //         write!(f, ": ")?;
-                    //     } else {
-                    //         write!(f, "+ ")?;
-                    //     }
-                    //     write!(f, "Send + Sync")?;
-                    // }
+                    if *required_sendable {
+                        if super_protocols.is_empty() {
+                            write!(f, ": ")?;
+                        } else {
+                            write!(f, "+ ")?;
+                        }
+                        write!(f, "Send + Sync")?;
+                    }
                     if *required_mainthreadonly {
                         if super_protocols.is_empty() {
                             write!(f, ": ")?;

crates/objc2/src/runtime/protocol_object.rs

@@ -208,7 +208,10 @@ mod tests {
 
     use super::*;
     use crate::runtime::{ClassBuilder, NSObject};
-    use crate::{define_class, extern_methods, extern_protocol, msg_send, ClassType};
+    use crate::{
+        define_class, extern_class, extern_conformance, extern_methods, extern_protocol, msg_send,
+        ClassType,
+    };
 
     extern_protocol!(
         unsafe trait Foo {
@@ -258,10 +261,21 @@ mod tests {
         unsafe impl NSObjectProtocol for DummyClass {}
     );
 
-    unsafe impl Foo for DummyClass {}
-    unsafe impl Bar for DummyClass {}
-    unsafe impl FooBar for DummyClass {}
-    // unsafe impl FooFooBar for DummyClass {}
+    extern_conformance!(
+        unsafe impl Foo for DummyClass {}
+    );
+
+    extern_conformance!(
+        unsafe impl Bar for DummyClass {}
+    );
+
+    extern_conformance!(
+        unsafe impl FooBar for DummyClass {}
+    );
+
+    // extern_conformance!(
+    //     unsafe impl FooFooBar for DummyClass {}
+    // );
 
     impl DummyClass {
         extern_methods!(
@@ -410,4 +424,30 @@ mod tests {
         let expected = format!("<My\u{f8ff}êÄClass: {:p}>", &*obj);
         assert_eq!(format!("{obj:?}"), expected);
     }
+
+    #[test]
+    fn send_sync() {
+        extern_protocol!(
+            #[name = "NSObject"]
+            unsafe trait SendableProtocol: Send + Sync {}
+        );
+
+        extern_class!(
+            #[unsafe(super(NSObject))]
+            #[name = "NSObject"]
+            struct SendableObject;
+        );
+
+        unsafe impl Send for SendableObject {}
+        unsafe impl Sync for SendableObject {}
+
+        extern_conformance!(
+            unsafe impl SendableProtocol for SendableObject {}
+        );
+
+        assert_impl_all!(ProtocolObject<dyn SendableProtocol>: Send, Sync);
+
+        let obj: Retained<SendableObject> = unsafe { msg_send![SendableObject::class(), new] };
+        let _proto: &ProtocolObject<dyn SendableProtocol> = ProtocolObject::from_ref(&*obj);
+    }
 }

crates/objc2/src/topics/FRAMEWORKS_CHANGELOG.md

@@ -40,6 +40,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 * **BREAKING**: Fixed structs with packed alignment by marking them `#[repr(packed(...))]`.
 * **BREAKING**: Fixed a few `MXMetricManager` methods that were instance methods instead of class methods.
 * Fixed missing deprecations on statics, type aliases and some impls blocks.
+* **BREAKING**: Fixed some protocols not being marked `Send + Sync` even when they should be.
+
+  This might break if you were implementing these yourself, in that case you should make your
+  implementee `Send + Sync` as well.
 
 ## [0.3.1] - 2025-04-19
 [0.3.1]: https://github.com/madsmtm/objc2/compare/frameworks-0.3.0...frameworks-0.3.1

crates/test-ui/ui/implement_protocol_missing_super.rs

@@ -1,5 +1,6 @@
 //! Test that implementing certain traits like `NSURLSessionDelegate` requires
-//! super protocols like `NSObjectProtocol` to also be implemented.
+//! super protocols like `NSObjectProtocol` and `Send + Sync` to also be
+//! implemented.
 use objc2::{define_class, MainThreadOnly};
 use objc2_foundation::{NSObject, NSURLSessionDelegate};