Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add chrome for testing support #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add chrome for testing support #28

wants to merge 1 commit into from

Conversation

nvdk
Copy link
Collaborator

@nvdk nvdk commented Mar 23, 2022

This fixes #26

@aliokan
Copy link
Contributor

aliokan commented Apr 12, 2023

@nvdk isn't template/Dockerfile that needs to be modified?

@aliokan aliokan mentioned this pull request Apr 12, 2023
Merged
@nvdk
Copy link
Collaborator Author

nvdk commented Apr 19, 2023

you're right, should find the time to update the PR

@nvdk
Copy link
Collaborator Author

nvdk commented Jun 1, 2023

This should be fixed now, I see the build is still failing but this is because the actual Dockerfile isn't updated.
I'll create a separate PR to add this to the testing pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing support
2 participants
@nvdk @aliokan