Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never ever edit files in source directory #600

Open
piwaneczko opened this issue Mar 10, 2022 · 2 comments
Open

Never ever edit files in source directory #600

piwaneczko opened this issue Mar 10, 2022 · 2 comments

Comments

@piwaneczko
Copy link

piwaneczko commented Mar 10, 2022

Why you are renaming file zconf.h to zconf.h.included in source files? (CMakeLists.txt:77)
It is making the git revision as dirty and force users to fetch your code to build directory instead to use it as a git submodule.
I see that you already have file zconf.h.in, so why you are not using configre_file function to generate zconf.h in build directory. Then only you need to do is to add target_include_directories(${PROJECT_NAME} PUBLIC ${CMAKE_CURRENT_BINARY_DIR}). zconf.h shall then be also be removed from source code.
Please consider it ASAP

@robotman2412
Copy link

I also ran into this issue, which makes my top level git repository state untracked changes and such.
This .included nonsense can't be disabled by revoking permission either because then the entire build fails!

@inkychris
Copy link

I've just submitted a pull request to resolve this as part of #162. It already uses configure_file but with zconf.h.cmakein instead of zconf.h.in.

This is a duplicate of #162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants