-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuGet package adds many unnecessary dependencies on .NET Core #56
Comments
@Brice-xCIT please double-check me, but I don't think that System.Diagnostics.Process gets pulled in by default for a netstandard build (I don't see it under https://www.nuget.org/packages/NETStandard.Library/). If that's true, then we do need this for a .NET standard build, which is what .NET core leverages currently. If this is available by default in netcoreapp, then perhaps we could add another build for netcoreapp20 or something that has no dependencies (like what we have for .NET framework). Thoughts? |
Hi @madelson, first of all sorry, I realized my diagnosis was wrong, the file size has not tremendously increased- something else was the culprit. |
@Brice-xCIT ok I think I understand the situation now. System.Diagnostics.Process was not included in .NET Standard 1.3 but IS included in .NET Standard 2.0. I've been specifying it as a dependency for both targets, but it looks like I can safely remove it from 2.0. I'll release a new version with the slimmer set of dependencies. Thanks for reporting! |
FYI a prerelease of 1.6.1 is available that has the slimmer dependency set. |
Hi, I'm using the 1.6.0 version of this lib from NuGet, in a netcore22 app. On this platform the NuGet package adds a dependency to System.Diagnostics.Process 4.3.0, which in turns adds many netfx dependencies. That seem a bit unnecessary to me, since Process and its dependencies are already in the core framework. The extra DLLs about quadrupled the size of my final package.
Is the dependency to System.Diagnostics.Process 4.3.0 necessary?
The text was updated successfully, but these errors were encountered: