feat(fgw): addition of a gateway + removal of starknet-provider #252

jbcaron · 2024-09-09T14:44:47Z

Pull Request type

Feature

What is the current behavior?

Resolves: #186

What is the new behavior?

Does this introduce a breaking change?

No

Other information

github-actions · 2024-09-09T15:05:02Z

Coverage report

The coverage rate is 69.10867865519937%

47% of new lines are covered.

Diff Coverage details (click to unfold)

crates/primitives/gateway/src/receipt.rs

80.0% of new lines are covered

crates/client/gateway/src/client/builder.rs

36.0% of new lines are covered

crates/primitives/receipt/src/into_starknet_core.rs

100.0% of new lines are covered

crates/primitives/receipt/src/lib.rs

83.33333333333334% of new lines are covered

crates/primitives/gateway/src/state_update.rs

100.0% of new lines are covered

crates/client/gateway/src/client/request_builder.rs

63.88888888888889% of new lines are covered

crates/primitives/receipt/src/from_blockifier.rs

0.0% of new lines are covered

crates/node/src/cli/gateway.rs

0.0% of new lines are covered

crates/client/gateway/src/server/worker.rs

0.0% of new lines are covered

crates/client/gateway/src/client/methods.rs

97.95918367346938% of new lines are covered

crates/primitives/gateway/src/transaction.rs

50.0% of new lines are covered

crates/client/gateway/src/server/handler.rs

0.0% of new lines are covered

crates/client/gateway/src/error.rs

0.0% of new lines are covered

crates/primitives/transactions/src/lib.rs

88.23529411764706% of new lines are covered

crates/node/src/main.rs

100.0% of new lines are covered

crates/primitives/gateway/src/block.rs

47.36842105263158% of new lines are covered

crates/primitives/receipt/src/from_starknet_provider.rs

100.0% of new lines are covered

crates/primitives/utils/src/lib.rs

100.0% of new lines are covered

crates/client/gateway/src/server/helpers.rs

0.0% of new lines are covered

crates/primitives/convert/src/hex_serde.rs

100.0% of new lines are covered

crates/client/gateway/src/server/router.rs

0.0% of new lines are covered

crates/node/src/service/gateway.rs

59.25925925925926% of new lines are covered

cchudant

cool!
I think we should move the client to another crate

cchudant · 2024-09-10T14:21:28Z

crates/primitives/gateway/src/block.rs

+
+#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
+#[serde(deny_unknown_fields)]
+pub struct BlockProvider {


why block provider name

rename it to GatewayBlock or something imo

crates/primitives/gateway/src/block.rs

crates/tests/src/lib.rs

crates/client/gateway/src/server/handler.rs

crates/client/gateway/src/server/router.rs

cchudant · 2024-09-10T15:02:37Z

crates/node/src/cli/gateway.rs

+
+    /// The gateway port to listen at.
+    #[arg(long, value_name = "GATEWAY PORT", default_value = "8080")]
+    pub gateway_port: u16,


maybe we want CORS at least here, i don't really know

this comment can be ignored for now but i think we want CORS settings like the rpcs @Trantorian1

cchudant · 2024-09-10T15:09:07Z

crates/client/block_import/src/verify_apply.rs

@@ -262,15 +262,15 @@ fn block_hash(
        parent_block_hash,
        block_number,
        global_state_root,
-        sequencer_address,
+        sequencer_address: Some(sequencer_address),


i don't have an opinion on whether we should have that as an option (same for the other 3 fields)

cchudant · 2024-09-10T15:13:27Z

crates/client/gateway/src/server/worker.rs

+        }
+    });
+
+    log::info!("🌐 Gateway endpoint started at {}", listener.local_addr());


if we add cors, match the message from rpc

log::info!( "📱 Running JSON-RPC server at {} (allowed origins={})", local_addr.map_or_else(|| "unknown".to_string(), |a| a.to_string()), format_cors(cors.as_ref()) );

Trantorian1

A few nitpicks, otherwise all seems good 👍

crates/client/gateway/src/client/methods.rs

crates/client/gateway/src/server/error.rs

crates/client/gateway/src/server/helpers.rs

cchudant

error handling isnt that clean yet

crates/client/gateway/src/server/error.rs

crates/client/gateway/src/server/handler.rs

crates/client/gateway/src/client/request_builder.rs

crates/client/gateway/src/server/handler.rs

crates/primitives/gateway/src/block.rs

crates/primitives/gateway/src/test.rs

crates/primitives/utils/src/lib.rs

crates/client/gateway/src/server/error.rs

crates/client/gateway/src/client/request_builder.rs

crates/client/gateway/src/client/methods.rs

> Note: This overrides the fgw url set by the current chain

crates/client/gateway/src/client/mod.rs

crates/client/sync/src/fetch/fetchers_real_fgw_test.rs

crates/client/sync/src/l2.rs

crates/node/src/cli/mod.rs

cchudant

perfect! very minor things that i noted, mostly just unwraps

crates/client/gateway/src/server/handler.rs

crates/primitives/gateway/src/receipt.rs

crates/client/gateway/src/client/builder.rs

crates/client/gateway/src/client/methods.rs

jbcaron added sequencer The label for sequencing related issues full node Full Node only related issues labels Sep 9, 2024

jbcaron self-assigned this Sep 9, 2024

jbcaron force-pushed the gateway branch 2 times, most recently from ba05390 to 4220b60 Compare September 9, 2024 14:54

jbcaron force-pushed the gateway branch 4 times, most recently from b9b65a8 to 38256b5 Compare September 10, 2024 11:32

cchudant reviewed Sep 10, 2024

View reviewed changes

antiyro marked this pull request as ready for review September 12, 2024 12:08

jbcaron force-pushed the gateway branch 4 times, most recently from bbbf378 to 4eb62dc Compare September 19, 2024 12:20

Trantorian1 approved these changes Sep 20, 2024

View reviewed changes

cchudant requested changes Sep 23, 2024

View reviewed changes

cchudant reviewed Sep 23, 2024

View reviewed changes

crates/client/gateway/src/client/request_builder.rs Outdated Show resolved Hide resolved

Mohiiit reviewed Sep 24, 2024

View reviewed changes

crates/client/gateway/src/client/methods.rs Outdated Show resolved Hide resolved

Trantorian1 force-pushed the gateway branch from 67787f9 to f54b361 Compare September 24, 2024 08:19

antiyro changed the title ~~feat: gateway~~ feat(fgw): addition of a gateway + removal of starknet-provider Sep 25, 2024

antiyro assigned Trantorian1 Sep 30, 2024

jbcaron and others added 7 commits October 1, 2024 09:14

gateway

36c1dd6

add add_transaction endpoint

372dc80

fix: disable_root

9834851

fix fmt

582f189

fix(comments)

da1bb7d

refactor(error): updated handler.rs error handling

cc87b39

fix(comments)

ae92369

Trantorian1 added 4 commits October 1, 2024 09:16

CHECKPOINT

51fb782

CHECKPOINT

d09b49c

feat(mocks): replaced json mocks with compressed gz mocks

68aefb1

fix(clippy)

b9b9625

jbcaron force-pushed the gateway branch from 8c73502 to b9b9625 Compare October 1, 2024 05:37

Trantorian1 added 11 commits October 1, 2024 08:39

refactor(rstest): removed redundant rstest in certain tests

cd5bc4b

fix(test): updated e2e tests to use fgw

63df3e2

fix(test): repaired mc-e2e-tests

f603a93

fix(test): repaired mc-sync tests

f016bdc

feat(fetch): added CLI option to set fgw url

4d24cad

> Note: This overrides the fgw url set by the current chain

fix(lint)

d5757a2

Merge branch 'main' into gateway

4ec67b8

fix(json): removed some test files

fe6775b

fix(prettier)

639ed14

fix(rate_limit): reverted MAX_RETRY to 15

75de1c4

fix(disable_root)

9339dcd

jbcaron commented Oct 2, 2024

View reviewed changes

crates/client/gateway/src/client/mod.rs Outdated Show resolved Hide resolved

crates/client/sync/src/fetch/fetchers_real_fgw_test.rs Outdated Show resolved Hide resolved

crates/client/sync/src/l2.rs Show resolved Hide resolved

crates/node/src/cli/mod.rs Outdated Show resolved Hide resolved

fix(feedback)

6bf5bae

cchudant approved these changes Oct 2, 2024

View reviewed changes

Trantorian1 added 4 commits October 2, 2024 11:37

fix(feedback)

d0a4f86

Merge branch 'main' into gateway

521d8fe

fix(ci): fixed out-of-order state update storage diffs

ac2d7d2

Merge branch 'main' into gateway

e719007

Trantorian1 force-pushed the gateway branch from 316fa36 to e719007 Compare October 2, 2024 13:11

antiyro approved these changes Oct 2, 2024

View reviewed changes

antiyro and others added 4 commits October 2, 2024 14:50

Merge branch 'main' into gateway

20cf3e7

Merge branch 'main' into gateway

4ad0ffa

fix(lint)

2adb31d

Merge branch 'main' into gateway

f898e9a

antiyro merged commit 0c821ae into main Oct 3, 2024
8 of 9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(fgw): addition of a gateway + removal of starknet-provider #252

feat(fgw): addition of a gateway + removal of starknet-provider #252

jbcaron commented Sep 9, 2024

github-actions bot commented Sep 9, 2024

crates/primitives/gateway/src/receipt.rs

crates/client/gateway/src/client/builder.rs

crates/primitives/receipt/src/into_starknet_core.rs

crates/primitives/receipt/src/lib.rs

crates/primitives/gateway/src/state_update.rs

crates/client/gateway/src/client/request_builder.rs

crates/primitives/receipt/src/from_blockifier.rs

crates/node/src/cli/gateway.rs

crates/client/gateway/src/server/worker.rs

crates/client/gateway/src/client/methods.rs

crates/primitives/gateway/src/transaction.rs

crates/client/gateway/src/server/handler.rs

crates/client/gateway/src/error.rs

crates/primitives/transactions/src/lib.rs

crates/node/src/main.rs

crates/primitives/gateway/src/block.rs

crates/primitives/receipt/src/from_starknet_provider.rs

crates/primitives/utils/src/lib.rs

crates/client/gateway/src/server/helpers.rs

crates/primitives/convert/src/hex_serde.rs

crates/client/gateway/src/server/router.rs

crates/node/src/service/gateway.rs

cchudant left a comment

cchudant Sep 10, 2024 •

edited

Loading

cchudant Sep 23, 2024

cchudant Sep 10, 2024

cchudant Sep 23, 2024

cchudant Sep 10, 2024

cchudant Sep 10, 2024

Trantorian1 left a comment

cchudant left a comment

cchudant left a comment

feat(fgw): addition of a gateway + removal of starknet-provider #252

feat(fgw): addition of a gateway + removal of starknet-provider #252

Conversation

jbcaron commented Sep 9, 2024

Pull Request type

What is the current behavior?

What is the new behavior?

Does this introduce a breaking change?

Other information

github-actions bot commented Sep 9, 2024

Coverage report

crates/primitives/gateway/src/receipt.rs

crates/client/gateway/src/client/builder.rs

crates/primitives/receipt/src/into_starknet_core.rs

crates/primitives/receipt/src/lib.rs

crates/primitives/gateway/src/state_update.rs

crates/client/gateway/src/client/request_builder.rs

crates/primitives/receipt/src/from_blockifier.rs

crates/node/src/cli/gateway.rs

crates/client/gateway/src/server/worker.rs

crates/client/gateway/src/client/methods.rs

crates/primitives/gateway/src/transaction.rs

crates/client/gateway/src/server/handler.rs

crates/client/gateway/src/error.rs

crates/primitives/transactions/src/lib.rs

crates/node/src/main.rs

crates/primitives/gateway/src/block.rs

crates/primitives/receipt/src/from_starknet_provider.rs

crates/primitives/utils/src/lib.rs

crates/client/gateway/src/server/helpers.rs

crates/primitives/convert/src/hex_serde.rs

crates/client/gateway/src/server/router.rs

crates/node/src/service/gateway.rs

cchudant left a comment

Choose a reason for hiding this comment

cchudant Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

cchudant Sep 23, 2024

Choose a reason for hiding this comment

cchudant Sep 10, 2024

Choose a reason for hiding this comment

cchudant Sep 23, 2024

Choose a reason for hiding this comment

cchudant Sep 10, 2024

Choose a reason for hiding this comment

cchudant Sep 10, 2024

Choose a reason for hiding this comment

Trantorian1 left a comment

Choose a reason for hiding this comment

cchudant left a comment

Choose a reason for hiding this comment

cchudant left a comment

Choose a reason for hiding this comment

cchudant Sep 10, 2024 •

edited

Loading