Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: added termination queue #56

Closed
wants to merge 9 commits into from
Closed

update: added termination queue #56

wants to merge 9 commits into from

Conversation

heemankv
Copy link
Contributor

@heemankv heemankv commented Jul 24, 2024 •
edited
Loading

This PR resolves Issue #55 .

  • Implemented Dead Letter Queue handler.
  • Adds last_job_status to job metadata.
  • Runs and Tests needs to spin up appropriate queues.
  • Test for handle_job_failure.

@heemankv heemankv added the enhancement New feature or request label Jul 24, 2024
@heemankv heemankv self-assigned this Jul 24, 2024
@heemankv heemankv linked an issue Jul 24, 2024 that may be closed by this pull request
Mark failed jobs in database. #55
Open
apoorvsadana
apoorvsadana reviewed Jul 24, 2024
View reviewed changes
crates/orchestrator/src/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/jobs/mod.rs Outdated Show resolved Hide resolved
apoorvsadana
apoorvsadana reviewed Jul 24, 2024
View reviewed changes
crates/orchestrator/src/queue/job_queue.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/queue/job_queue.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/queue/job_queue.rs Outdated Show resolved Hide resolved
@heemankv heemankv changed the base branch from main to feat/increasing-test-coverage July 30, 2024 07:00
apoorvsadana
apoorvsadana reviewed Jul 30, 2024
View reviewed changes
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/jobs/mod.rs Outdated Show resolved Hide resolved
@apoorvsadana apoorvsadana self-requested a review August 2, 2024 17:43
apoorvsadana
apoorvsadana reviewed Aug 7, 2024
View reviewed changes
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/jobs/mod.rs Outdated Show resolved Hide resolved
Base automatically changed from feat/increasing-test-coverage to main August 7, 2024 14:48
@apoorvsadana apoorvsadana changed the base branch from main to feat/increasing-test-coverage August 8, 2024 13:18
@apoorvsadana apoorvsadana mentioned this pull request Aug 8, 2024
Merged
@apoorvsadana
Copy link
Contributor

Closing in favor of #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvsadana apoorvsadana apoorvsadana approved these changes

Assignees

@heemankv heemankv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark failed jobs in database.
2 participants
@heemankv @apoorvsadana