We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the with_settings usage. We need to decide how and where should we read config variables from - env or json. env is easier to to config when hosting but json is more readable. Currently, the usage of with_settings seems to be incorrect in a few places where we read an env after fetching the settings from the provider (https://github.com/karnotxyz/madara-orchestrator/blob/7baf1903b50fb52815fdf5b4e65733ec0076620d/crates/settlement-clients/ethereum/src/lib.rs#L40-L40). This seems incorrect, we need to figure out a coherent approach and implement it.
with_settings
env
json
The text was updated successfully, but these errors were encountered:
ocdbytes
No branches or pull requests
Refactor the
with_settings
usage. We need to decide how and where should we read config variables from -env
orjson
.env
is easier to to config when hosting butjson
is more readable. Currently, the usage ofwith_settings
seems to be incorrect in a few places where we read anenv
after fetching the settings from the provider (https://github.com/karnotxyz/madara-orchestrator/blob/7baf1903b50fb52815fdf5b4e65733ec0076620d/crates/settlement-clients/ethereum/src/lib.rs#L40-L40). This seems incorrect, we need to figure out a coherent approach and implement it.The text was updated successfully, but these errors were encountered: