We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lean
As discovered by Miri, the lean variant of beef leaks memory. I verified that by adding this patch
diff --git a/src/generic.rs b/src/generic.rs index add1a9b..9fa0981 100644 --- a/src/generic.rs +++ b/src/generic.rs @@ -170,6 +170,7 @@ where #[inline] fn drop(&mut self) { if let Some(capacity) = self.capacity() { + panic!("dropping!"); unsafe { T::owned_from_parts::<U>(self.inner, capacity) }; } }
and then running cargo test lean. Clearly that should drop the contents and thus panic at some point, but it does not.
cargo test lean
The text was updated successfully, but these errors were encountered:
Oh dear me, when I was reimplementing this into generics I've made two separate mistakes that both separately cause this: 2e75601#diff-b722bb40412152063337bda6ba389775
line 23: MASK_HI was always 0. line 50: capacity was zeroed before bitshifted.
MASK_HI
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
As discovered by Miri, the
lean
variant of beef leaks memory. I verified that by adding this patchand then running
cargo test lean
. Clearly that should drop the contents and thus panic at some point, but it does not.The text was updated successfully, but these errors were encountered: