Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an initial release #3

Closed
gbraad opened this issue May 31, 2018 · 9 comments
Closed

Make an initial release #3

gbraad opened this issue May 31, 2018 · 9 comments

Comments

@gbraad
Copy link
Member

gbraad commented May 31, 2018

No description provided.

@gbraad
Copy link
Member Author

gbraad commented May 31, 2018

docker#4424 (comment)

@afbjorklund
Copy link

@gbraad:
Would it be possible to merge b36cb27 ? Now it looks like there's a lot of changes since 1903531
When in fact it is "only" a rebase of master (for some reason), and one new commit 6f34be4 ...

* 821e8c7 (docker/master) Fix changelog date
* 12b8f37 Changelog 0.16.0
| * 702c267 (tag: v0.16.0) Bump version to 0.16.0
|/  
* 15cde71 (tag: 0.16.0) Fix typo
* 46b43eb Update path of golint
* b36cb27 openstack: don't fail when trying to delete non-existing keypair
* 7909ee3 Fix integrate tests of core commands cases
* dccdee0 aws ec2 preqreq check: match error to filter
* 6971794 amazonec2: correct mis-handling of 'none' VPC
* 7768a5b Use latest docker/docker revision
* 9ec6729 Fix wrong docker daemon process name of engine options tests
* 6c90ba4 Return error of command exec in SSH NativeClient
* 7a9ce45 Update "aufs" to "overlay2" in several places
* dfdca21 change default storage driver for redhat
| * 6f34be4 (machine-drivers/master) Allow localized names for Virtual Switch
| * 7ef2969 openstack: don't fail when trying to delete non-existing keypair
| * 8ff1a71 Fix integrate tests of core commands cases
| * ae80b71 aws ec2 preqreq check: match error to filter
| * 3f0e438 amazonec2: correct mis-handling of 'none' VPC
| * 771052d Use latest docker/docker revision
| * 2d3369d Fix wrong docker daemon process name of engine options tests
| * 245427f Return error of command exec in SSH NativeClient
| * ea7d4b7 Update "aufs" to "overlay2" in several places
| * f9347cb change default storage driver for redhat
|/  
* 1903531 fix invalid ignorance of bin directory
* 4f225c9 Add PR template
* eae38c1 Update CHANGELOG - v0.15.0
| * b48dc28 (tag: v0.15.0) Bump version to 0.15.0
|/  
*   1e4713b (tag: 0.15.0) Merge pull request #4477 from shahiddev/master

Or maybe just merge all of it, and go from 0.15 to 0.16 ?

If anything, maybe revert 4f225c9 since it is confusing.

@afbjorklund
Copy link

Added, #13

Haven't done any reverts, and leaved the new commit.

@gbraad
Copy link
Member Author

gbraad commented Jan 19, 2019

merged

@afbjorklund
Copy link

Seems like most of the libmachine consumers are happy without official releases ?

minikube: 0.15.0-3-g1903531 (1903531) <-- I tagged 'v0.15.0^' as 0.15.0 (1e4713b)

minishift: 0.15.0-13-g6f34be4 (6f34be4) <-- almost the same as 0.16.0~2 (b36cb27)

And that the releases are mostly for the docker-machine binaries. So maybe not important...

@gbraad
Copy link
Member Author

gbraad commented Jan 20, 2019 via email

@afbjorklund
Copy link

The boot2podman story is slightly different, as I actually changed the API (e.g. removed swarm).
Even for minikube (and minishift?), that seems the easiest way to e.g. support different CRI.

But since that major change hasn't happened yet, there is no need to make it "almost" the same.
Might as well keep the docker-machine/boot2docker "compatibility", until it is fully severed ?

@afbjorklund
Copy link

For now, the workaround there is just to stop docker after machine is "done". And then start up crio.
The boot2docker.iso are already implemented differently, but it follows the same "specification" still...

@gbraad
Copy link
Member Author

gbraad commented Jan 20, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants