"FancyName" is used instead of "ParamName"

[ewanwm]

Is it really right to use the FancyName inside the covariance objects?

MaCh3/covariance/covarianceBase.cpp

Line 208 in f22c853

_fFancyNames[i] = Get<std::string>(param["Systematic"]["Names"]["FancyName"], __FILE__ , __LINE__);

MaCh3/covariance/covarianceBase.cpp

Line 230 in f22c853

CorrNamesMap[param["Systematic"]["Names"]["FancyName"].as<std::string>()]=i;

To me the regular parameter name should be used internally and "FancyName" should only be used for e.g. plotting, printing etc.
I can't actually find anywhere that "ParameterName" is used at the moment.

Didn't want to just change this as it would probably break all existing config files :)

[KSkwarczynski]

I agree this is confusing. I think there was initally idea as you outline, but so many processing relies on names being xsec_XX

Right now normal name is xsec_XX (autogenerated), while fancy name Eb_XX

- Systematic:
    Names:
      FancyName: EB_dial_C_nu

    Correlations:
    - EB_dial_C_nubar: '0.778'

I think expansion of this issue should be how we store parameter names in MCMC tree and how processing works.