Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generatejson.py doesn't have all features #28

Closed
erikng opened this issue Jan 8, 2018 · 4 comments
Closed

generatejson.py doesn't have all features #28

erikng opened this issue Jan 8, 2018 · 4 comments

Comments

@erikng
Copy link
Member

erikng commented Jan 8, 2018

Currently, generatejson.py lacks the following features

scripts

  • userscripts
  • rootscripts
  • donotwait flag

stages

  • preflight
@rickheil
Copy link
Contributor

rickheil commented Jan 8, 2018

See #29 for pkg receipts and versions

@rickheil
Copy link
Contributor

rickheil commented Feb 2, 2018

Here's a suggested directory structure to make this work with the existing featureset.

rootdir/
├── preflight
├── setupassistant
│   └── forced
└── userland
    ├── forced
    ├── rootscript
    │   ├── donotwait
    │   └── wait
    └── userscript
        ├── donotwait
        └── wait

I can also add a switch to make generatejson.py create the directory structure at the passed rootdir since we're introducing more complication for the admin.
Execution order should remain the same since (alphanumeric) - will probably need to sort the python dict to preserve this since a simple listing of files may not capture it between wait/donotwait.

Thoughts?

@erikng
Copy link
Member Author

erikng commented Feb 2, 2018

think you are almost there, but missing a few things:

rootdir/
├── preflight
├── setupassistant
    ├── pkgs
    │   └── forced
    ├── rootscript
    │   ├── donotwait
    │   └── wait
└── userland
    ├── pkgs
    │   └── forced
    ├── rootscript
    │   ├── donotwait
    │   └── wait
    └── userscript
        ├── donotwait
        └── wait

And I like the idea of creating the directory structure with a switch.

@erikng
Copy link
Member Author

erikng commented May 23, 2018

Addressed with 65f1f38

@erikng erikng closed this as completed May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants