Skip to content

Commit 5173d53

Browse files
authored
fix(InputNumber): add button type attribute, fixes primefaces#5700
Adds a button type to html button element to prevent form submits when placed within a form.
1 parent 1305a23 commit 5173d53

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

components/lib/inputnumber/InputNumber.vue

+4-4
Original file line numberDiff line numberDiff line change
@@ -30,29 +30,29 @@
3030
/>
3131
<span v-if="showButtons && buttonLayout === 'stacked'" :class="cx('buttonGroup')" v-bind="ptm('buttonGroup')">
3232
<slot name="incrementbutton" :listeners="upButtonListeners">
33-
<button :class="[cx('incrementButton'), incrementButtonClass]" v-on="upButtonListeners" :disabled="disabled" :tabindex="-1" aria-hidden="true" v-bind="ptm('incrementButton')">
33+
<button :class="[cx('incrementButton'), incrementButtonClass]" v-on="upButtonListeners" :disabled="disabled" :tabindex="-1" aria-hidden="true" v-bind="ptm('incrementButton')" type="button">
3434
<slot :name="$slots.incrementicon ? 'incrementicon' : 'incrementbuttonicon'">
3535
<component :is="incrementIcon || incrementButtonIcon ? 'span' : 'AngleUpIcon'" :class="[incrementIcon, incrementButtonIcon]" v-bind="ptm('incrementIcon')" data-pc-section="incrementicon" />
3636
</slot>
3737
</button>
3838
</slot>
3939
<slot name="decrementbutton" :listeners="downButtonListeners">
40-
<button :class="[cx('decrementButton'), decrementButtonClass]" v-on="downButtonListeners" :disabled="disabled" :tabindex="-1" aria-hidden="true" v-bind="ptm('decrementButton')">
40+
<button :class="[cx('decrementButton'), decrementButtonClass]" v-on="downButtonListeners" :disabled="disabled" :tabindex="-1" aria-hidden="true" v-bind="ptm('decrementButton')" type="button">
4141
<slot :name="$slots.decrementicon ? 'decrementicon' : 'decrementbuttonicon'">
4242
<component :is="decrementIcon || decrementButtonIcon ? 'span' : 'AngleDownIcon'" :class="[decrementIcon, decrementButtonIcon]" v-bind="ptm('decrementIcon')" data-pc-section="decrementicon" />
4343
</slot>
4444
</button>
4545
</slot>
4646
</span>
4747
<slot name="incrementbutton" :listeners="upButtonListeners">
48-
<button v-if="showButtons && buttonLayout !== 'stacked'" :class="[cx('incrementButton'), incrementButtonClass]" v-on="upButtonListeners" :disabled="disabled" :tabindex="-1" aria-hidden="true" v-bind="ptm('incrementButton')">
48+
<button v-if="showButtons && buttonLayout !== 'stacked'" :class="[cx('incrementButton'), incrementButtonClass]" v-on="upButtonListeners" :disabled="disabled" :tabindex="-1" aria-hidden="true" v-bind="ptm('incrementButton')" type="button">
4949
<slot :name="$slots.incrementicon ? 'incrementicon' : 'incrementbuttonicon'">
5050
<component :is="incrementIcon || incrementButtonIcon ? 'span' : 'AngleUpIcon'" :class="[incrementIcon, incrementButtonIcon]" v-bind="ptm('incrementIcon')" data-pc-section="incrementicon" />
5151
</slot>
5252
</button>
5353
</slot>
5454
<slot name="decrementbutton" :listeners="downButtonListeners">
55-
<button v-if="showButtons && buttonLayout !== 'stacked'" :class="[cx('decrementButton'), decrementButtonClass]" v-on="downButtonListeners" :disabled="disabled" :tabindex="-1" aria-hidden="true" v-bind="ptm('decrementButton')">
55+
<button v-if="showButtons && buttonLayout !== 'stacked'" :class="[cx('decrementButton'), decrementButtonClass]" v-on="downButtonListeners" :disabled="disabled" :tabindex="-1" aria-hidden="true" v-bind="ptm('decrementButton')" type="button">
5656
<slot :name="$slots.decrementicon ? 'decrementicon' : 'decrementbuttonicon'">
5757
<component :is="decrementIcon || decrementButtonIcon ? 'span' : 'AngleDownIcon'" :class="[decrementIcon, decrementButtonIcon]" v-bind="ptm('decrementIcon')" data-pc-section="decrementicon" />
5858
</slot>

0 commit comments

Comments
 (0)