Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issues/suggestions on flake.nix and .gitignore #2453

Open
4 tasks
LEXUGE opened this issue Jun 20, 2024 · 2 comments
Open
4 tasks

Minor issues/suggestions on flake.nix and .gitignore #2453

LEXUGE opened this issue Jun 20, 2024 · 2 comments

Comments

@LEXUGE
Copy link
Contributor

LEXUGE commented Jun 20, 2024

ARTIQ Feature Request

Problem this request addresses

Several minor issues/suggestions on flake.nix and .gitignore

  • add result produced by nix to .gitignore, and refactor .gitignore.
  • format flake.nix by nixpkgs-fmt, a formatter used by nixpkgs.
  • use flake-utils to avoid boilerplates like openocd-bscanspi-f and manually writing out pkgs-aarch64 and pkgs
  • use pre-commit-hooks to automatically check formatting and lints with flake8, nixpkgs-fmt, and rustfmt before commit and with nix flake check.

Additional context

I locally tested flake8 lint, it seems the python codebase has a lot of lint errors.

@sbourdeauducq
Copy link
Member

  • to automatically check formatting and lints with flake8, nixpkgs-fmt

Is nixpkgs-fmt available on non-Nix platforms?

@LEXUGE
Copy link
Contributor Author

LEXUGE commented Jun 20, 2024

You can install by cargo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants