Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndt7: early exit #316

Open
stephen-soltesz opened this issue Aug 10, 2020 · 2 comments
Open

ndt7: early exit #316

stephen-soltesz opened this issue Aug 10, 2020 · 2 comments
Labels

Comments

@stephen-soltesz
Copy link
Contributor

After BBR stabilizes, the download connection may exit early.

@gfr10598
Copy link
Contributor

gfr10598 commented Sep 9, 2020

I'd like to suggest that we make this an option selected by the client, with "legacy" as the default indefinitely.

  1. aggressive-pacing-gain - terminates after the first positive crossing from <1 to >=1
  2. conservative-pacing-gain - terminates after the second (or 3rd?) positive crossing
  3. legacy - no early termination.

We might want to experiment with RTT based early termination as well. But the variance between 5th and 95th percentile MinRTT within the pacing-gain based bins is huge, so I'm guessing this won't work nearly as well.

However, there might be some benefit to waiting a minimum of 10 MinRTT before terminating. There seem to be a few ill-behaved tests where the unity gain crossing seems to come within just a couple MinRTTs, which seems wrong.

@gfr10598
Copy link
Contributor

gfr10598 commented Sep 9, 2020

BTW, with first unity crossing, there is a roughly 8x reduction in server download network utilization!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants