Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task.Close should return error, and Process... should handle and/or propagate that error. #985

Open
gfr10598 opened this issue Apr 12, 2021 · 2 comments

Comments

@gfr10598
Copy link
Contributor

gfr10598 commented Apr 12, 2021

func (tt *Task) Close() {

Currently, these errors are dropped - not reported to Gardener.

Among these errors are GCS write errors, reported on

etl/storage/rowwriter.go

Lines 168 to 169 in 5caa9cb

attr, err := rw.o.Update(ctx, oa)
log.Println(attr, err)

@autolabel autolabel bot added the review/triage Team should review and assign priority label Apr 12, 2021
@gfr10598 gfr10598 changed the title should return error? Task.Close should return error, and Process... should handle and/or propagate that error. Apr 12, 2021
@gfr10598
Copy link
Contributor Author

There are also insufficient permission errors that should be propagated.

@laiyi-ohlsen
Copy link

@stephen-soltesz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants