Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sys.CPU_CORES was renamed in Julia 1.0 #42

Closed
DilumAluthge opened this issue Jan 22, 2021 · 1 comment
Closed

Sys.CPU_CORES was renamed in Julia 1.0 #42

DilumAluthge opened this issue Jan 22, 2021 · 1 comment

Comments

@DilumAluthge
Copy link

The docstring for CpuId.cpucores says:

help?> CpuId.cpucores
  cpucores()

  Determine the number of physical cores on the current executing CPU by invoking a
  cpuid instruction. On systems with multiple CPUs, this only gives information on the
  single CPU that is executing the code. Returns zero if querying this feature is not
  supported, which may also be due to a running hypervisor (as observed on hvvendor() ==
  :Microsoft).

  Also, this function does not take logical cores (aka hyperthreading) into account, but
  determines the true number of physical cores, which typically also share L3 caches and
  main memory bandwidth.

  See also the Julia global variable Base.Sys.CPU_CORES, which gives the total count of
  all cores on the machine.

However, as of Julia 1.0, Sys.CPU_CORES has been renamed to Sys.CPU_THREADS (see JuliaLang/julia#27856, JuliaLang/julia#28091, and JuliaLang/julia@1f1b1b8).

Should the docstring be updated?

@m-j-w
Copy link
Owner

m-j-w commented Jan 23, 2021

Good catch. Resolved in merged #44

@m-j-w m-j-w closed this as completed Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants