Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 6.0 as a Runtime dependecy or some kind of warning #27

Open
maxkerp opened this issue Sep 21, 2021 · 0 comments
Open

Add Rails 6.0 as a Runtime dependecy or some kind of warning #27

maxkerp opened this issue Sep 21, 2021 · 0 comments

Comments

@maxkerp
Copy link

maxkerp commented Sep 21, 2021

Hi there, just a little feedback.

We are still on rails 5.2 for one of our apps and did not update the gem for a while. Now that we did we ran into an issue with the method ActionView::Template::Handlers::ERB.call which does not have the source parameter on rails 5.2.

So if I don't miss something this gem is only compatible with rails ~> 6.0 starting with version 0.3.5.

Adding this to your runtime dependency or some kind of warning or even an Exception when its used with rails <= 6.0 could be really helpful and save the next developer some time.

Anyway thanks a lot for providing this gem! It's much appreciated ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant