diff --git a/.changeset/tiny-pianos-enter.md b/.changeset/tiny-pianos-enter.md new file mode 100644 index 0000000000..aa04d4b71b --- /dev/null +++ b/.changeset/tiny-pianos-enter.md @@ -0,0 +1,5 @@ +--- +"@lynx-js/web-elements": patch +--- + +fix: line-height of markdown-style should be added `px` diff --git a/packages/web-platform/web-elements/src/elements/XMarkdown/XMarkdownAttributes.ts b/packages/web-platform/web-elements/src/elements/XMarkdown/XMarkdownAttributes.ts index dfa7b1a1bb..c9a6b6e444 100644 --- a/packages/web-platform/web-elements/src/elements/XMarkdown/XMarkdownAttributes.ts +++ b/packages/web-platform/web-elements/src/elements/XMarkdown/XMarkdownAttributes.ts @@ -380,7 +380,6 @@ const preprocessInlineView = (html: string) => const unitlessCssProperties = new Set([ 'font-weight', - 'line-height', 'opacity', 'z-index', 'flex', diff --git a/packages/web-platform/web-elements/tests/fixtures/x-markdown/style.html b/packages/web-platform/web-elements/tests/fixtures/x-markdown/style.html index 2013fa7eb8..e6333a6020 100644 --- a/packages/web-platform/web-elements/tests/fixtures/x-markdown/style.html +++ b/packages/web-platform/web-elements/tests/fixtures/x-markdown/style.html @@ -36,6 +36,7 @@ }, link: { color: 'ff0000', + lineHeight: 24, }, inlineCode: { color: '0000ff', diff --git a/packages/web-platform/web-elements/tests/x-markdown.spec.ts b/packages/web-platform/web-elements/tests/x-markdown.spec.ts index 050e128a41..336e9fb70b 100644 --- a/packages/web-platform/web-elements/tests/x-markdown.spec.ts +++ b/packages/web-platform/web-elements/tests/x-markdown.spec.ts @@ -104,9 +104,14 @@ test.describe('x-markdown', () => { test('should apply markdown-style updates', async ({ page }) => { await goto(page, 'x-markdown/style'); const markdown = page.locator('x-markdown'); + await page.waitForFunction(() => { + const element = document.querySelector('x-markdown'); + return element?.shadowRoot?.querySelector('a')?.textContent === 'link'; + }); const link = markdown.locator('a'); await expect(link).toHaveCSS('color', 'rgb(255, 0, 0)'); + await expect(link).toHaveCSS('line-height', '24px'); const inlineCode = markdown.locator('code').first(); await expect(inlineCode).toHaveCSS('color', 'rgb(0, 0, 255)');