From d63d4828fe8f6f48ac721d17f3ab2460e577893b Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 29 Jan 2026 11:56:50 +0000 Subject: [PATCH 1/4] Initial plan From f3ac72b718d2e0e9901b0ea9c1bab112a9776152 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 29 Jan 2026 12:24:05 +0000 Subject: [PATCH 2/4] feat: add x-list scrollHeight getter Co-authored-by: PupilTong <12288479+PupilTong@users.noreply.github.com> --- .github/lynx-stack.instructions.md | 5 +++++ .../web-platform/web-elements/src/elements/XList/XList.ts | 4 ++++ .../web-platform/web-elements/tests/web-elements.spec.ts | 8 ++++++++ 3 files changed, 17 insertions(+) create mode 100644 .github/lynx-stack.instructions.md diff --git a/.github/lynx-stack.instructions.md b/.github/lynx-stack.instructions.md new file mode 100644 index 0000000000..54c8f0f100 --- /dev/null +++ b/.github/lynx-stack.instructions.md @@ -0,0 +1,5 @@ +--- +applyTo: "packages/web-platform/web-elements/**/*" +--- + +When updating web element APIs, add targeted Playwright tests in packages/web-platform/web-elements/tests/web-elements.spec.ts and keep changes minimal. diff --git a/packages/web-platform/web-elements/src/elements/XList/XList.ts b/packages/web-platform/web-elements/src/elements/XList/XList.ts index 234c70a4b4..11649ae565 100644 --- a/packages/web-platform/web-elements/src/elements/XList/XList.ts +++ b/packages/web-platform/web-elements/src/elements/XList/XList.ts @@ -46,6 +46,10 @@ export class XList extends HTMLElement { this.#getListContainer().scrollLeft = val; } + override get scrollHeight() { + return this.#getListContainer().scrollHeight; + } + get __scrollTop() { return super.scrollTop; } diff --git a/packages/web-platform/web-elements/tests/web-elements.spec.ts b/packages/web-platform/web-elements/tests/web-elements.spec.ts index 9de74f0fb8..590c46621e 100644 --- a/packages/web-platform/web-elements/tests/web-elements.spec.ts +++ b/packages/web-platform/web-elements/tests/web-elements.spec.ts @@ -2141,11 +2141,15 @@ test.describe('web-elements test suite', () => { return (document.querySelector('x-list') as any) ?.getScrollContainerInfo(); })).jsonValue(); + const scrollHeight1 = await page.evaluate(() => { + return (document.querySelector('x-list') as any)?.scrollHeight; + }); expect( typeof info1 === 'object' && info1.scrollLeft === 0 && info1.scrollTop === 0 && info1.scrollHeight !== 0 && info1.scrollWidth !== 0, ).toBeTruthy(); + expect(scrollHeight1).toBe(info1.scrollHeight); await page.evaluate(() => document.querySelector('x-list')?.shadowRoot?.querySelector( '#content', @@ -2157,11 +2161,15 @@ test.describe('web-elements test suite', () => { return (document.querySelector('x-list') as any) ?.getScrollContainerInfo(); })).jsonValue(); + const scrollHeight2 = await page.evaluate(() => { + return (document.querySelector('x-list') as any)?.scrollHeight; + }); expect( typeof info2 === 'object' && info2.scrollLeft === 200 && info2.scrollTop === 200 && info2.scrollHeight !== 0 && info2.scrollWidth !== 0, ).toBeTruthy(); + expect(scrollHeight2).toBe(info2.scrollHeight); }, ); From 4f7181dcfe81a622d194156e3ec3da39aa7f3be5 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 29 Jan 2026 12:30:32 +0000 Subject: [PATCH 3/4] test: cover x-list scrollWidth getter Co-authored-by: PupilTong <12288479+PupilTong@users.noreply.github.com> --- .../web-platform/web-elements/src/elements/XList/XList.ts | 4 ++++ .../web-platform/web-elements/tests/web-elements.spec.ts | 8 ++++++++ 2 files changed, 12 insertions(+) diff --git a/packages/web-platform/web-elements/src/elements/XList/XList.ts b/packages/web-platform/web-elements/src/elements/XList/XList.ts index 11649ae565..ed84847c7f 100644 --- a/packages/web-platform/web-elements/src/elements/XList/XList.ts +++ b/packages/web-platform/web-elements/src/elements/XList/XList.ts @@ -50,6 +50,10 @@ export class XList extends HTMLElement { return this.#getListContainer().scrollHeight; } + override get scrollWidth() { + return this.#getListContainer().scrollWidth; + } + get __scrollTop() { return super.scrollTop; } diff --git a/packages/web-platform/web-elements/tests/web-elements.spec.ts b/packages/web-platform/web-elements/tests/web-elements.spec.ts index 590c46621e..4f4e0b668e 100644 --- a/packages/web-platform/web-elements/tests/web-elements.spec.ts +++ b/packages/web-platform/web-elements/tests/web-elements.spec.ts @@ -2144,12 +2144,16 @@ test.describe('web-elements test suite', () => { const scrollHeight1 = await page.evaluate(() => { return (document.querySelector('x-list') as any)?.scrollHeight; }); + const scrollWidth1 = await page.evaluate(() => { + return (document.querySelector('x-list') as any)?.scrollWidth; + }); expect( typeof info1 === 'object' && info1.scrollLeft === 0 && info1.scrollTop === 0 && info1.scrollHeight !== 0 && info1.scrollWidth !== 0, ).toBeTruthy(); expect(scrollHeight1).toBe(info1.scrollHeight); + expect(scrollWidth1).toBe(info1.scrollWidth); await page.evaluate(() => document.querySelector('x-list')?.shadowRoot?.querySelector( '#content', @@ -2164,12 +2168,16 @@ test.describe('web-elements test suite', () => { const scrollHeight2 = await page.evaluate(() => { return (document.querySelector('x-list') as any)?.scrollHeight; }); + const scrollWidth2 = await page.evaluate(() => { + return (document.querySelector('x-list') as any)?.scrollWidth; + }); expect( typeof info2 === 'object' && info2.scrollLeft === 200 && info2.scrollTop === 200 && info2.scrollHeight !== 0 && info2.scrollWidth !== 0, ).toBeTruthy(); expect(scrollHeight2).toBe(info2.scrollHeight); + expect(scrollWidth2).toBe(info2.scrollWidth); }, ); From 28c18625487530f4b5546f7ac4998c2e86e8e93f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 2 Feb 2026 03:52:06 +0000 Subject: [PATCH 4/4] chore: add changeset for x-list scroll metrics Co-authored-by: PupilTong <12288479+PupilTong@users.noreply.github.com> --- .changeset/bright-apes-begin.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/bright-apes-begin.md diff --git a/.changeset/bright-apes-begin.md b/.changeset/bright-apes-begin.md new file mode 100644 index 0000000000..59a383449c --- /dev/null +++ b/.changeset/bright-apes-begin.md @@ -0,0 +1,5 @@ +--- +"@lynx-js/web-elements": patch +--- + +Add scrollHeight/scrollWidth getters to XList.