Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Typescript Recommended Guidelines on the Frontend library #503

Closed
Golodhros opened this issue Jun 9, 2020 · 1 comment
Closed
Labels
area:frontend From the Frontend folder help wanted Extra attention is needed status:needs_votes Issue or bug fix that needs support from the community to be considered type:maintenance A regular maintenance chore or task, including refactors, build system, CI, performance improvements

Comments

@Golodhros
Copy link
Member

We have setup code linting with ESLint and added some basic rules like the 'react/recommended' to our project.

To make sure we use best practices, reduce our code review effort and provide the best developer experience for our contributors, I suggest to extend the linting rules with the Typescript Recommended rules ('plugin:@typescript-eslint/recommended') on the extends portion of our ESLint configuration.

Possible Implementation

The Typescript plugin is already in the system. The work on this ticket would entail adding 'plugin:@typescript-eslint/recommended') on the extends portion of our ESLint configuration. Then, we would need to run npm run lint to see all the errors and one by one fix those.

Context

Following strict coding rules for our code benefits Amundsen as:

  • We spend less time on code reviews
  • We provide a great developer experience to our contributors, increasing the chances of obtaining more help and reducing churn
  • We signal that we are a serious project that care about code quality and good practices
  • We make subsequent changes easier

Also, for TypeScript, getting this rules implemented would make our codebase more type safe.

@Golodhros Golodhros added help wanted Extra attention is needed Project: Frontend status:needs_votes Issue or bug fix that needs support from the community to be considered type:maintenance A regular maintenance chore or task, including refactors, build system, CI, performance improvements labels Jun 9, 2020
@stale
Copy link

stale bot commented Jun 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jun 23, 2020
@feng-tao feng-tao added the keep fresh Disables stalebot from closing an issue label Jul 10, 2020
@stale stale bot removed the stale label Jul 10, 2020
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
…ns empty dict (amundsen-io#503)

* Make sure not to crash when user search returns empty dict

* Fix for the total result too
feng-tao pushed a commit that referenced this issue May 7, 2021
…ns empty dict (#503)

* Make sure not to crash when user search returns empty dict

* Fix for the total result too
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
…ns empty dict (amundsen-io#503)

* Make sure not to crash when user search returns empty dict

* Fix for the total result too
@Golodhros Golodhros added area:frontend From the Frontend folder and removed Project: Frontend labels Dec 15, 2022
@Golodhros Golodhros removed the keep fresh Disables stalebot from closing an issue label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend From the Frontend folder help wanted Extra attention is needed status:needs_votes Issue or bug fix that needs support from the community to be considered type:maintenance A regular maintenance chore or task, including refactors, build system, CI, performance improvements
Projects
None yet
Development

No branches or pull requests

2 participants