Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narwhalify ModeImputer #321

Closed
davidhopkinson26 opened this issue Oct 7, 2024 · 2 comments
Closed

Narwhalify ModeImputer #321

davidhopkinson26 opened this issue Oct 7, 2024 · 2 comments
Assignees

Comments

@davidhopkinson26
Copy link
Contributor

What

make ModeImputer polars compatible while maintaining backwards compatibility with pandas.

Why?

Making the project polars compatible for speed benefits. Narwhals allows us to do this piece by piece and maintain compatibility between components as it makes it possible to pass pandas dataframes to polars logic. This involves converting between pandas/polars dataframes.

How?

convert logic in ModeImputer to function with polars dataframes and add narwhalify decorators to methods to ensure compatibility with pandas dataframes.

Update testing where required.

@limlam96
Copy link
Contributor

think this will be relevant narwhals-dev/narwhals#981

@limlam96
Copy link
Contributor

limlam96 commented Nov 7, 2024

PR #345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants