Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create generic 'learnt_attributes' tests #265

Open
limlam96 opened this issue Jul 2, 2024 · 0 comments
Open

Create generic 'learnt_attributes' tests #265

limlam96 opened this issue Jul 2, 2024 · 0 comments

Comments

@limlam96
Copy link
Contributor

limlam96 commented Jul 2, 2024

What?
Many transformers have tests like 'test_learnt_values_not_modified', which currently not abstracted because learnt_attributes have many different names. If we stored linked transformers/learnt_attributes in a test fixture, we could then move these tests into parent test classes and reduce duplication

Why?
Reduce test duplication

How?
Create dict in conftest matching transformers to learnt attributes, and use this fixture to move relevant tests in the generic test classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant