Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jupyter notebook linting via CI #191

Open
adamsardar opened this issue Mar 4, 2024 · 0 comments
Open

jupyter notebook linting via CI #191

adamsardar opened this issue Mar 4, 2024 · 0 comments
Labels
CI improvements to continuous integration good first issue Good for newcomers

Comments

@adamsardar
Copy link
Contributor

What

Enable jupyter linting support in our CI pipelines (via ruff)

Why

Our examples are still part of our codebase, so much be under linting control. We used to have a stage in the pre-commit template that linted jupyter notebooks, but running it through CI is superior (single source of truth that can't be turned off).

How

Follow the instructions in the ruff docs to enable jupyter linting and fix any failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI improvements to continuous integration good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamsardar @davidhopkinson26