Mr #169
Merged
Mr #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* openssl version 1.0.1-4 (precise) shows 'error 23' but exits with 0 * openssl version 1.0.1f (trusty) shows 'error 23' but exits with 2
| @@ -264,9 +302,10 @@ | |||
| notify => Exec["generate ${name}.ovpn in ${server}"], | |||
| } | |||
|
|
|||
| $name_escaped = regsubst(regsubst($name, '\.', '\\.', 'G'), '@', '\\@', 'G') | |||
There was a problem hiding this comment.
Do I understand this line correctly as that the following replacements will be done?
.=>\.@=>\@
There was a problem hiding this comment.
This is true.
It was required for us as we use full e-mail addresses in resource title. The former version works fine as long as simple user names are used (plain alphanumeric). In our case, Perl's regular expression handling would treat those characters special and in turns wont match properly.
|
Thanks, @mklette. I added some comments inline, looking forward to your replies. |
|
The tls-cipher feature would be nice.... but I guess that's what $custom_options is for... |
luxflux
added a commit
that referenced
this pull request
Sep 15, 2015
|
Thank you, @mklette! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
may I kindly ask you for reviewing these changes? Please let me know of any doubts you may have about merging and I'll try to complete the changes.
Thanks
Mathias