Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch benches to hzkg/bn254 #292

Merged
merged 1 commit into from
Feb 14, 2024
Merged

chore: switch benches to hzkg/bn254 #292

merged 1 commit into from
Feb 14, 2024

Conversation

huitseeker
Copy link
Contributor

Fixes #278

@huitseeker
Copy link
Contributor Author

!gpu-benchmark

adr1anh
adr1anh previously approved these changes Feb 2, 2024
View reviewed changes
@huitseeker
Copy link
Contributor Author

huitseeker commented Feb 6, 2024 •
edited
Loading

Note to self: investigating #281, and keeping the pasta benches at hand for that reason: it's easier if I have direct access to the same benches as those that showed the difference in speed betw. GPU/GPU-less.

@storojs72 storojs72 self-requested a review February 12, 2024 15:39
storojs72
storojs72 previously approved these changes Feb 12, 2024
View reviewed changes
@samuelburnham
Copy link
Contributor

!benchmark --features cuda,asm

@huitseeker huitseeker dismissed stale reviews from storojs72 and adr1anh via e53708a February 14, 2024 14:48
@huitseeker
Copy link
Contributor Author

Now that I have the data for a branch that does not have any calls to the MSM in the IPA (which shows no change), I'm comfortable merging this.

@huitseeker huitseeker enabled auto-merge February 14, 2024 14:49
@storojs72 storojs72 self-requested a review February 14, 2024 15:00
@github-actions GitHub Actions
Copy link
Contributor

Benchmark for 4cc09c8

Click to view benchmark
Test Base PR %
CompressedSNARK-NIVC-Commitments-2/Prove/StepCircuitSize-514444 58.2±0.80s 27.4±0.76s -52.92%
CompressedSNARK-NIVC-Commitments-2/Prove/StepCircuitSize-6540 14.5±0.13s 11.1±0.17s -23.45%
CompressedSNARK-NIVC-Commitments-2/Verify/StepCircuitSize-514444 423.8±1.55ms 46.7±0.53ms -88.98%
CompressedSNARK-NIVC-Commitments-2/Verify/StepCircuitSize-6540 83.4±0.67ms 46.5±0.43ms -44.24%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-514444 211.9±0.91ms 198.1±1.41ms -6.51%
RecursiveSNARK-NIVC-2/Prove/StepCircuitSize-6540 53.9±0.36ms 45.3±0.37ms -15.96%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-514444 154.7±3.46ms 149.6±2.78ms -3.30%
RecursiveSNARK-NIVC-2/Verify/StepCircuitSize-6540 34.8±0.67ms 35.6±0.64ms +2.30%

@huitseeker huitseeker added this pull request to the merge queue Feb 14, 2024
Merged via the queue into lurk-lang:dev with commit 46ef318 Feb 14, 2024
9 checks passed
@huitseeker huitseeker deleted the to_bn254 branch February 14, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpenciak mpenciak mpenciak approved these changes

@storojs72 storojs72 storojs72 approved these changes

@adr1anh adr1anh adr1anh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: fix default GPU benchmark to run
5 participants
@huitseeker @samuelburnham @adr1anh @storojs72 @mpenciak