Refactor 'kzg_verify_batch' closure in MLKZG verification #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adr1anh
reviewed
Jan 4, 2024
src/provider/mlkzg.rs
Outdated
Comment on lines
337
to
341
| let L = NE::GE::vartime_multiscalar_mul(&q_powers_multiplied[..k], &C[..k]) | ||
| - E::G1::from(vk.g) * (B_u[0] + d_0 * B_u[1] + d_1 * B_u[2]) | ||
| + E::G1::from(W[0]) * u[0] | ||
| + E::G1::from(W[1]) * (u[1] * d[0]) | ||
| + E::G1::from(W[2]) * (u[2] * d[1]); | ||
| + E::G1::from(W[1]) * (u[1] * d_0) | ||
| + E::G1::from(W[2]) * (u[2] * d_1); |
There was a problem hiding this comment.
L can be computed using a single call to vartime_multiscalar_mul, with inputs
[q_powers_multiplied[..k], vk.g, W[0], W[1], W[2]][C[..k], (B_u[0] + d_0 * B_u[1] + d_1 * B_u[2]), u[0], (u[1] * d_0), (u[2] * d_1)]
In the context where we are writing the verifier can use an MSM implementation like in Solidity, this should be a bit more efficient than computing individual scalar multiplications .
There was a problem hiding this comment.
Yes, indeed! Added this refactoring in e1a5b15
adr1anh
previously approved these changes
Jan 4, 2024
huitseeker
reviewed
Jan 4, 2024
huitseeker
added a commit
to huitseeker/arecibo
that referenced
this pull request
Jan 14, 2024
…ications (lurk-lang#231) * refactor: simplify type aliases in tests (lurk-lang#54) Generic type aliases are type functions. In our case, they are made distinct through the arguments they are passed, not by giving them different names. * Simplify map_or expressions, remove clippy override noise, improve doc (lurk-lang#57) * refactor: Rewrite some exact instances of `Result::ok()` * refactor: Increase Clippy lint complexity limits and remove overrides - Removed Clippy linting restrictions on complexity and argument count across several modules including r1cs, lib, supernova/circuit, and bellpepper/shape_cs among others. - added .clippy.toml config file for project-wide limits * doc: Improve markdown formatting - Improved code documentation throughout by adding markdown styling and backticks for code readability. - No major functionality changes conducted,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229